On 05/01/12, [email protected] wrote:
> very high lever/initial comments to get started (its a huge change!):
>
> * what kind of testing has been done? like e.g. all the unit tests?
So far I just have copied over my 'minitest' tests under
'server/tests/drivers/api'. Those should run fine against this patchset.
The other test suites must be updated to work with Sinatra::Base. I'm
currently working on this update.
> * very nice - tidying up of each collections to separate file
> * nice autoloading of models
> * where are blob streaming hacks? (used to be in blob_stream.rb) ("Core:
> Removed deprecated helpers")
Sorry for this. Seems like I removed more that I should remove. I copied
the file back and load it in lib/deltacloud/helpers.
> * I tried cd /server; rake rabbit:routes but got "rake aborted!
> uninitialized constant Deltacloud" - pebkac?
Right. This is caused by 'deltacloud-core' gem. If this gem is installed,
it try to load it and not the one in current directory. I'll try to figure
out how to avoid that. A simple workaround would be to uninstall
deltacloud-core gem.
> * couldn't start the server. I installed sinatra-rabbit:
Same issue as above ^^.
> [marios@name server]$ irb -rubygems
> irb(main):001:0> require 'sinatra/rabbit'
> NameError: uninitialized constant Deltacloud
> from
> /usr/lib/ruby/gems/1.8/gems/deltacloud-core-0.4.1/lib/deltacloud/validation.rb:17
> from
OK so I should focus on validation file, thanks :-)
Thanks a ton for looking on this patch. I found some 19 compat issues in
routing and I will try to fix it today and sent an updated patchset.
-- Michal
> On 17/04/12 16:39, [email protected] wrote:
> > From: Michal Fojtik <[email protected]>
> >
> >
> > Signed-off-by: Michal fojtik <[email protected]>
> > ---
> > server/deltacloud-core.gemspec | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/server/deltacloud-core.gemspec b/server/deltacloud-core.gemspec
> > index 55aa182..54d88cc 100644
> > --- a/server/deltacloud-core.gemspec
> > +++ b/server/deltacloud-core.gemspec
> > @@ -68,6 +68,7 @@ Gem::Specification.new do |s|
> > s.add_dependency('rake', '>= 0.8.7')
> > s.add_dependency('haml', '>= 2.2.17')
> > s.add_dependency('sinatra', '>= 0.9.4')
> > + s.add_dependency('sinatra-rabbit', '>= 1.0.5')
> > s.add_dependency('rack', '>= 1.0.0')
> > s.add_dependency('rack-accept')
> > s.add_dependency('json', '>= 1.1.9')
>
--
Michal Fojtik
Sr. Software Engineer, Deltacloud API (http://deltacloud.org)
