On 05/02/12, Hugh O. Brock wrote:
> On Wed, May 02, 2012 at 03:47:38PM +0200, [email protected] wrote:
> > From: Michal Fojtik <[email protected]>
> > 
> > 
> > Signed-off-by: Michal fojtik <[email protected]>
> > ---
> >  server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb 
> > b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> > index 1c96df7..9e8dcc4 100644
> > --- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> > +++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> > @@ -190,6 +190,7 @@ class RHEVMDriver < Deltacloud::BaseDriver
> >        params[:cores] = opts[:hwp_cpu] if opts[:hwp_cpu]
> >        params[:user_data] = opts[:user_data].gsub(/\n/,'') if 
> > opts[:user_data]
> >        params[:fileinject_path] = "deltacloud-user-data.txt"
> > +      params[:display] = 'spice'
> >        convert_instance(client, client.create_vm(params))
> >      end
> >    end
> > -- 
> 
> Michal, I don't know if it's reasonable to have params[:display]
> always set to 'spice', do you? What would happen in the event the user
> didn't have a spice client available?

Yes, we should make this as a 'feature' (I wonder if we can do something
similar in other clouds, like openstack or vsphere). So so far ignore pls
this patch, I'll send another one.

> Also: Is there a workaround for customers with existing CloudForms
> installations? It's way too late for code changes for the 1.0 release.

The only workaround that will not involve any code changes I can think of
is to update the RHEV-M DB (some command will do the job), to set 'spice'
as the 'default' display mode.

IMHO the 'spice' is already preferred by default for RHEV-M.

  -- Michal

> 
> Take care,
> --Hugh
> 
> -- 
> == Hugh Brock, [email protected]                                   ==
> == Engineering Manager, Cloud BU                                   ==
> == Aeolus Project: Manage virtual infrastructure across clouds.    ==
> == http://aeolusproject.org                                        ==
> 
> "I know that you believe you understand what you think I said, but I’m
> not sure you realize that what you heard is not what I meant."
> --Robert McCloskey

-- 
Michal Fojtik
Sr. Software Engineer, Deltacloud API (http://deltacloud.org)

Reply via email to