On 05/10/12, David Lutterkort wrote: > On Tue, 2012-04-17 at 15:39 +0200, [email protected] wrote: > > From: Michal Fojtik <[email protected]> > > [ I am looking at your branch, but it's more convenient to reply to > individual patches ] > > This and 2/32 seem like a little too much magic to me; why do this > rather than have a big server.rb ? It's 1200 lines right now, but they > are fairly boring code, and I like being able to see all that code at > once.
Sorry, I was too fast with replying ;-) You are referring to the collection subfolder not to lazy-loading. My thoughts was to make it more readable and structured when it will be splitted into separate files. Having everything in one place is nice but when you first look into the server.rb it honestly looks like a mess :-) IMHO having the collections in separate files will make it more easy to fix things in particular collection, without making people rebasing and fixing conflicts in one big server.rb. Also since this code use Base class from Sinatra, all collections are just 'modules' that can be plugged and un-plugged as needed. So you can for example use DC as base for your application where you choose just collections you really want to use. Another thing is that I guess in future we will need to add more collections, like for managing networks/etc so the amount of code in server.rb will eventually grow. I think that for the people that want to add new collection to Deltacloud, it's now more easy just 'copy' the collection file, rename it and add their stuff there. -- Michal -- Michal Fojtik Sr. Software Engineer, Deltacloud API (http://deltacloud.org)
