On Fri, 2012-07-20 at 18:12 -0700, David Lutterkort wrote:
> On Fri, 2012-07-20 at 19:55 +0300, [email protected] wrote:
> > Initial API tests rewrite - these are intended as 'black box' tests,
> > i.e. to be pointed at a deltacloud API server running somewhere and
> > interacting only with the API and not with deltacloud internals
> > (as described in more detail http://piratepad.net/deltacloud-testing
> > ). Uses RestClient to do the talking.
>
> Looks good. I have a whole bunch of comments, which I put in the form of
> patches[1] ;)
>
> The patch series applies on top of your 2/2 and should just be squashed
> into it. There's a few more changes I'd like to make, but that will have
> to wait until Monday.
I've added a few more patches to my patch series at [1] - in particular,
patches 10/14 and higher are new.
Besides shuffling code around, there's now a couple helpers to suppress
test runs when collections or features are missing:
describe "collection frob" do
need_collection :frobs
need_feature :frobs, :user_name
it "lists all frobs" do
...
end
end
The one thing I am not too happy about is that it leads to skipped
tests, which is kinda ugly when you run 'rake test:deltacloud
TESTOPT="-v"' - I couldn't find a good way to suppress tests quietly.
David
[1] http://people.apache.org/~lutter/patches/tests-rewrite/
