FGCP returns an error in this case as I wasn't aware of this convention. Where do I find such conventions? Surely not only in the commit messages?
Regards, Dies Koper > -----Original Message----- > From: David Lutterkort [mailto:[email protected]] > Sent: Thursday, 26 July 2012 8:32 AM > To: [email protected] > Subject: Re: [PATCH core 1/7] RHEV-M: Fixed bug that cause instance not > pick up image_id > > On Wed, 2012-07-25 at 15:23 +0200, [email protected] wrote: > > From: Michal Fojtik <[email protected]> > > > > > > Signed-off-by: Michal fojtik <[email protected]> > > --- > > server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb | 13 +++++++++-- > -- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > ACK. It would be good if the commit message explained in more detail > what is being fixed here; something like the following in the body of > the commit message: > > * images: by convention, drivers return an empty array if > opts[:id] is specified but no image with that id exists > * create_instance: fix typo > * convert_image: image state needs to be uppercase > > The last point raises the question of whether we shouldn't map RHEV-M > image states to a fixed set of DC image states ... > > David > >
