On Aug 29, 2012, at 1:35 AM, lut...@redhat.com wrote:
Hi,
This set looks cool, however I still got two errors when running
tests on 1.9:
<snip>
test_0003_must allow to filter realms(Ec2Driver Realms):
Deltacloud::ExceptionHandler::ProviderError: undefined method `to_a' for
"us-east-1a":String
/Users/mfojtik/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/aws-2.5.6/lib/ec2/ec2.rb:1119:in
`describe_availability_zones'
/Users/mfojtik/code/core/server/lib/deltacloud/drivers/ec2/ec2_driver.rb:184:in
`block in realms'
</snip>
Attached patch seems to fix that. Also I got some warnings in tests:
<snip>
instance_test.rb:94: warning: class variable access from toplevel
instance_test.rb:94: warning: class variable access from toplevel
</snip>
But that is safe to ignore IMHO.
ACK if you include my patch ;]
-- Michal
>
> rev2
> ----
>
> This time with tests, and with rerecordings so that existing tests don't
> break.
>
> rev1
> ----
>
> As recently discussed, these patches make it possible to launch instances
> into a subnet in a VPC in EC2.
>
> Subnets appear as new realms with the name AZ:SN where AZ is the
> availability zone (e.g., us-east-1a) to which the subnet is attached, and
> SN is the subnet ID.
>
> When such a realm is supplied to the create instances call, the SubnetID is
> sent to EC2, placing the instane in that subnet.
>
> Note that you can not provide a security group when launching into a VPC,
> which makes the current HTML UI a little awkward, in that you have to
> uncheck the 'default' security group in the UI under 'Additional
> Parameters'
>
> The VPC functionality requires some additional mappings from the AWS gem,
> which I have sent upstream[1] - until they are in a released AWS gem, I am
> including a monkey patch that puts them into the AWS::Ec2 class.
>
> David
Michal Fojtik
http://deltacloud.org
mfoj...@redhat.com
