On Sep 12, 2012, at 12:42 AM, David Lutterkort <[email protected]> wrote:

> On Tue, 2012-09-11 at 14:49 +0200, [email protected] wrote:
>> From: Michal Fojtik <[email protected]>
>> 
>> * Moved '[CIMI|Deltacloud]::Base' class to base_collection.rb.
>> Having this Sinatra class in 'helpers.rb' is not very intuitive.
> 
> Why not move it to {cimi,deltacloud}/collections/base.rb (rather than
> base_collection.rb) ?
> 
> That's where I'd expect it to be given the class is
> {Deltacloud,CIMI}::Collections::Base

Yes, good catch. I renamed the base_collection to base and also
rebased against latest master.

http://tracker.deltacloud.org/set/57

 - Michal

Reply via email to