On Sat, 2012-09-22 at 00:33 +0200, [email protected] wrote: > From: Michal Fojtik <[email protected]> > > Instead of using $stderr directly, use Ruby > Logger class to wrap them. In future it will be > easier to redirect to 'errors.log'. > > Signed-off-by: Michal fojtik <[email protected]>
ACK; one nit: > diff --git a/server/lib/deltacloud/drivers/exceptions.rb > b/server/lib/deltacloud/drivers/exceptions.rb > index 1a635ce..57b57ef 100644 > --- a/server/lib/deltacloud/drivers/exceptions.rb > +++ b/server/lib/deltacloud/drivers/exceptions.rb > @@ -178,6 +178,11 @@ module Deltacloud > end > end > > + def self.logger(logger=nil) > + @logger ||= logger Is that really what you want here ? This is equivalent to '@logger = logger unless @logger'; it seems more logical to do '@logger = logger if logger' > + @logger || ::Logger.new($stderr) You mean '||=' here, right ? David
