> From: "Dies Koper" <di...@fast.au.fujitsu.com> > To: dev@deltacloud.apache.org > Sent: Tuesday, February 26, 2013 7:24:38 PM > Subject: RE: Deltacloud - Tests - adding testpoint for creating an image from > a stopped instance - if supported > > Hi Ronelle, > > Thanks for picking this up. It was on my todo list but have been > focusing on cimi system first. > > > - checks if the create_image op exists on the running instance > > - if not, stops the instance > > - and checks if the create_image op now exists > > Should the test also cater for the possibility that a provider > supports create_image for both running and stopped instances? > I don't know if we have any such providers. If not, I suppose we can > revisit the test when we do.
Dies, thanks for the review. I don't know of any providers that allow a user to create and image from both a running and a stopped instance so I think we're ok with switching on the instance state here. If you find such a provider, let me know :) > > > - starts the instance if it was stopped in step 2 > > Maybe there is no need for this? > None of the other tests rely on the instance to be running so it > could be left in the stopped state. Agreed, I didn't see an exact need to restart the instance other than that I wanted to cleanup. Could likely remove this. > > Regards, > Dies Koper > > -- > Dies KÖPER > Software & Solutions Architect > > Fujitsu Australia Software Technology (FAST) - Cloud Computing > Tel. +61 2 9452 9061 (Fujitsu internal 7985-29061) > di...@fast.au.fujitsu.com > > > > -----Original Message----- > > From: rla...@redhat.com [mailto:rla...@redhat.com] > > Sent: Wednesday, 27 February 2013 10:02 AM > > To: dev@deltacloud.apache.org > > Subject: Deltacloud - Tests - adding testpoint for creating an > > image from > > a stopped instance - if supported > > > > > > We lost this testing when all instances were started prior to > > running > > the instances testpoints. This patch: > > > > - checks if the create_image op exists on the running instance > > - if not, stops the instance > > - and checks if the create_image op now exists > > - if so, carries on with the test and creates the image > > - starts the instabce if it was stopped in step 2 > > > > I've dons some preliminary testing on RHEVM, Mock ... assuming that > > there > > will be little fallout for the providers that support image > > creation from > > a running instance (fgcp and c2) - where this code will just be > > skipped > > over. > > > > >
