On 03/01, David Lutterkort wrote:
> On Fri, 2013-03-01 at 14:40 +0100, Michal Fojtik wrote:
> > - ResourceMetada are now broken and need to be fixed.
> > (an informative warning included ;-)
>
> I added one more patch to your series and rerecorded as
> http://tracker.deltacloud.org/set/364
Great! I tried it and it works as expected. I have just one question about
RMD attrs in models. What if someone will try to use the models to
de/serialize CIMI to models in his own app. In that case the 'realm' and
'driver', which are DC specific attrs will appear in his model as
'required' attrs.
Does it have sense to inject that attrs to models dynamically? Like the
'metadata' method we have in Service models, will open the schema of
the inherited Model class and add these attributes?
But don't take this as a review blocker, I am perfectly fine with merging
this patches to master as they are now (maybe delete the FIXME: one ;-).
Also we should discuss what name we will give to the new CIMI models gem.
If we name it 'deltacloud-cimi-models', we can scare off some potential
users/contributors, because they will think this is DC specific gem.
What about just 'cimi-models' or just 'cimi' ("gem install cimi" sounds
kewl ;-).
Next question is versioning. We definitely need to have some constant in
models code (perhaps base.rb) to say for what version of CIMI these models
are supposed to work (CIMI::VERSION = '1.0.1', etc...).
Maybe crazy idea would be to also include the CIMI version in the gem
version itself, like:
cimi-1.0.1.RELEASE.gem
where we will just bumb the RELEASE number as we will need.
Cheers,
-- Michal
> > - The filter_by and select_by methods moved to .find, so no longer
> > ugly chains in Rabbit collections.
>
> Nice .. this is good, because ultimately we might need to want to pass
> some of this to drivers to avoid querying useless data.
>
> > David: Can you have look on RMD? I think we reached the problem with
> > lambdas :-)
>
> Things look fairly good now; there's still one test that fails, and the
> patches need to massaged a little. With a little more testing we are
> probably good to commit this.
>
> David
>
>
--
Michal Fojtik <mfoj...@redhat.com>
Deltacloud API, CloudForms
