On 03/14/2013 05:31 PM, David Lutterkort wrote:
> On Wed, 2013-03-13 at 17:28 -0400, jvlcek wrote:
>> On 03/13/2013 01:41 PM, David Lutterkort wrote:
>>> On Wed, 2013-03-13 at 08:50 -0400, jvlcek wrote:
>>>> On 03/12/2013 06:26 PM, David Lutterkort wrote:
>>>>> On Tue, 2013-03-12 at 17:39 -0400, jvl...@redhat.com wrote:
>>>>>> From: Joe VLcek <jvl...@redhat.com>
>>>>>>
>>>>>> This is required to better describe recent changes
>>>>>> for parameterizing recording and provider configuration
>>>>>> of credentials and resources to avoid having to edit
>>>>>> test source code in order to record test fixtures.
>>>>>> ---
>>>>>> site/content/running-the-white-box-tests.md | 25 ++++--
>>>>>> .../update-vcr-test-fixtures-data-example.md | 95
>>>>>> ++++++----------------
>>>>>> site/output/running-the-white-box-tests.html | 25 ++++--
>>>>>> .../update-vcr-test-fixtures-data-example.html | 94
>>>>>> ++++++---------------
>>>>>> 4 files changed, 84 insertions(+), 155 deletions(-)
>>>>>> diff --git a/site/content/update-vcr-test-fixtures-data-example.md
>>>>>> b/site/content/update-vcr-test-fixtures-data-example.md
>>>>>> index 2f8074a..ef64573 100644
>>>>>> --- a/site/content/update-vcr-test-fixtures-data-example.md
>>>>>> +++ b/site/content/update-vcr-test-fixtures-data-example.md
>>>>>> @@ -29,62 +29,44 @@ More information can be found on the past recording
>>>>>> of the
>>>>>> <ol>
>>>>>> <li>
>>>>>> <p> Create ${HOME}/.deltacloud/config</p>
>>>>>> + <br>
>>>>>> + <p> Create the deltacloud config file:
>>>>>> ${HOME}/.deltacloud/config</p>
>>>>>> + to contain the credentials and provider resource UUIDs</p>
>>>>>>
>>>>>> <pre>
>>>>>> rhevm:
>>>>>> user: 'admin@internal'
>>>>>> password: 'localpassword'
>>>>>> - provider:
>>>>>> 'https://16.1.1.3/api;b9bb11c2-f397-4f41-a57b-7ac15a894779'
>>>>>> - mock:
>>>>>> - user: mockuser
>>>>>> - password: mockpassword
>>>>>> - provider: compute
>>>>>> + provider: 'https://rhevm.example.com/api'
>>>>>> + preferred:
>>>>>> + datacenter: UUID of a datacenter/realm
>>>>>> + vm: UUID of an existing instance
>>>>>> + template: UUID of an existing template/image
>>>>> Why did you remove mock here ? It was a good way to show people how to
>>>>> add credentials for additional drivers. It's also useful when you run
>>>>> 'deltacloudd -c'
>>>> I removed mock: because this is a specific example for rhevm and I
>>>> didn't want to confuse the user into thinking they needed the mock:
>>>> entry to make this example work.
>>>>
>>>> If you think it adds value for this example I can surely add it back.
>>> Fair enough.
>>>
>>>>>> - <p>Modify the test source to have the realm, instance, image &
>>>>>> provider
>>>>>> - for a live cloud provider.</p>
>>>>>> + <p>Set the VCR record mode to <i>all</i></p>
>>>>>> + <br>
>>>>>> + <p> Note: This does not cause <i>all</i> tests to be recorded.
>>>>>> + It instructs VCR to record new fixtures data for the test to
>>>>>> + be run in the next step.</p>
>>>>> Can you modify the other tests to use VCR_RECORD to trigger recording ?
>>>> I had thought that this change would migrate out to the other tests as
>>>> re-recording become required for them.
>>>>
>>>> Can doing that be done separately from this SITE doc change?
>>> Sure .. I'd just like for you to go through the various
>>> tests/drivers/*/common.rb files and make that change. It doesn't require
>>> rerecording fixtures.
>>>
>>>>>> <li>
>>>>>> - <p>Remove trailing white space from the fixtures YAML files.</p>
>>>>>> + <p>Deal sith trailing white space from the fixtures YAML files.</p>
>>>>> Tyop, and I don't think we need this section. It's fine to check the
>>>>> YAML files in with trailing ws.
>>>> It just conflicts with what we recommend on
>>>> http://deltacloud.apache.org/send-patch.html
>>>> for the git config file.
>>>> e.g.:
>>>> ...
>>>>
>>>> [apply]
>>>> whitespace = error-all
>>>> ...
>>>>
>>>> So I wanted to mention it here so folks won't get bit by it as they
>>>> follow through the steps outlined on:
>>>> http://deltacloud.apache.org/how-to-contribute.html
>>> Ok .. is there any way we can remove that contradiction without forcing
>>> people to do stuff to YAML files for ws removal ? Whitespace errors are
>>> mostly interesting in code.
>>>
>>> David
>>>
>>>
>> Hey David,
>>
>> I've posted:
>>
>> http://tracker.deltacloud.org/set/388
>>
>> I believe it addresses all the issues you've raised.
>> If it does can you please ack and push it for me? I
>> don't yet have push rights.
> ACK; please also make sure to remove older versions of the patch from
> tracker.
>
> David
>
>
Thank you for the help David.
I've removed the older versions of the patch from tracker.
Joe
