Michal,
Thank you for all your replies!
I've successfully run the client tests and
applied http://tracker.deltacloud.org/set/403
Everything looks good to me. I only have a couple
of comments in the attached patch that you can
apply on top of tracker set 403.
Hope this helps!
Joe V.
>From 6d77a646d8ab04351d82db857145523f76037109 Mon Sep 17 00:00:00 2001
From: Joe VLcek <jvl...@redhat.com>
Date: Tue, 26 Mar 2013 11:09:14 -0400
Subject: [PATCH] JoeV response to reply
---
client/lib/deltacloud/client.rb | 6 ++++++
client/lib/deltacloud/client/models/base.rb | 5 +++++
client/lib/deltacloud/client/models/image.rb | 3 +++
3 files changed, 14 insertions(+)
diff --git a/client/lib/deltacloud/client.rb b/client/lib/deltacloud/client.rb
index 8fbc52d..2cfce9e 100644
--- a/client/lib/deltacloud/client.rb
+++ b/client/lib/deltacloud/client.rb
@@ -71,6 +71,12 @@ module Deltacloud
# Maybe we can do Deltacloud::Client::Connection.valid?(url)
# and then do just a syntax sugar here :)
#
+ # @JoeV:
+ # I'll leave it up to you but it seems to me it would be more
+ # consistent to do Deltacloud::Client::Connection.valid?(url)
+ # and then just add some syntax sugar here :)
+ # or maybe I'm missing something
+ #
def self.valid_connection?(api_url)
begin
Deltacloud::Client(api_url, '', '') && true
diff --git a/client/lib/deltacloud/client/models/base.rb b/client/lib/deltacloud/client/models/base.rb
index 9109527..85d3b86 100644
--- a/client/lib/deltacloud/client/models/base.rb
+++ b/client/lib/deltacloud/client/models/base.rb
@@ -54,6 +54,11 @@ module Deltacloud::Client
# way because of uglyness of 'client.instance("inst1").obj_id'
# I much more like 'client.instance("inst1")._id' :-)
#
+ # @ JoeV
+ # Really? I don't think 'client.instance("inst1").obj_id' is ugly.
+ # I think having the alias and the "_" is ugly.
+ #
+
alias_method :_id, :obj_id
# Populate instance variables in model
diff --git a/client/lib/deltacloud/client/models/image.rb b/client/lib/deltacloud/client/models/image.rb
index 59039ac..101ddcf 100644
--- a/client/lib/deltacloud/client/models/image.rb
+++ b/client/lib/deltacloud/client/models/image.rb
@@ -40,6 +40,9 @@ module Deltacloud::Client
# client.image('img1').launch(:hwp_id => 'm1-small')
#
# For me it does sound more natural :-)
+ #
+ # JoeV - Ah! Yes I see now.
+ #
# From technical point of view, this method is just an syntax sugar.
# In addition to 'create_instance', as a bonus :) it will check if the
# 'hwp_id' parameter value is 'allowed' to be used with this image.
--
1.7.11.7
