[ 
https://issues.apache.org/jira/browse/DTACLOUD-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638955#comment-13638955
 ] 

Marios Andreou commented on DTACLOUD-549:
-----------------------------------------

ACK

First of all I should say that I don't have access to arubacloud; if you are 
able to provide some testing/dev credentials it would be helpful in testing 
these patches more properly. From a visual inspection I can't see anything 
seriously wrong; the patches apply cleanly and the server starts with the 
arubacloud driver with no complaints.

Can you please confirm that these patches address:

https://issues.apache.org/jira/browse/DTACLOUD-548
https://issues.apache.org/jira/browse/DTACLOUD-490
https://issues.apache.org/jira/browse/DTACLOUD-389

If so I can go ahead and resolve/close those issues too. Before I push these I 
will fix a minor typo in /site/content/drivers.md ("YWithin a single (master) 
account you can have many storgae") and generate the output (html) files too 
before pushing to site.

Finally, for future, you might consider splitting your driver into 
arubacloud_driver and arubacloud_client - you can put all the helper methods 
for rest_client/savon (like "request", "get_all", "storage_request",  
"generate_headers") could be moved there. But this is just a suggestion - 
whatever works best for you,

marios
                
> Added storage functionalities to Arubacloud driver
> --------------------------------------------------
>
>                 Key: DTACLOUD-549
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-549
>             Project: DeltaCloud
>          Issue Type: Improvement
>          Components: Server
>            Reporter: Aruba Staff
>            Assignee: Marios Andreou
>            Priority: Minor
>         Attachments: 
> 0001-Updated-Arubacloud-driver-and-fixed-DTACLOUD-389.patch, 
> 0002-First-release-of-storage-for-Arubacloud-driver.patch, 
> 0003-Changed-entrypoint-selection-for-Deltacloud-storage-.patch
>
>
> Please find attached patch for storage support in Arubacloud driver

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to