[ 
https://issues.apache.org/jira/browse/DELTASPIKE-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853844#comment-13853844
 ] 

Romain Manni-Bucau commented on DELTASPIKE-473:
-----------------------------------------------

done this way this is too intrusive and will lead to issue when deployed in 
another JavaEE 7 container. The fact DS uses another packaging is nice to be 
portable accross containers (and DS includes JavaEE 6).

BTW making DS @Transactional closer to JavaEE 7 would be sane IMHO.

> Add support for javax.transaction.Transactional annotation added in JTA 1.2 
> spec
> --------------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-473
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-473
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: Data-Module, JPA-Module, TestControl
>    Affects Versions: 0.6
>            Reporter: Ivan Vasyliev
>             Fix For: 0.6
>
>         Attachments: add_jta_1_2_into_deltaspike.patch
>
>
> https://www.youtube.com/watch?v=rChkWy2NFyQ
> The @Transactional annotation is already part of JavaEE, so there is no need 
> to have custom one. 
> The idea is to reuse code from JTA implementation. The one which  already 
> supports 1.2 is Jbosstm(Narayana). I've made an attempt to incorporate it 
> into deltaspike. Please see attached changes and testcase. 
> Few notes on it:
> - The producers for openwebbeans and weld are different, I've made 
> openwebbeans ones
> - There is 2 system preferences which needs to be set to make narayana create 
> system folders under proper location (see surefire plugin config)
> - Latest hibernate can autodetect JTA platform
> - I did not make attempt to create generic datasource registration function, 
> this maybe subject for other issue



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to