[ 
https://issues.apache.org/jira/browse/DELTASPIKE-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858089#comment-13858089
 ] 

Ivan Vasyliev edited comment on DELTASPIKE-473 at 12/28/13 6:14 PM:
--------------------------------------------------------------------

I'm not sure why you closed this feature request because of issue in one 
particular proposed solution, but anyway: I compiled example on how to plug my 
patch into deltaspike w/o affecting its core deps: 
https://github.com/vasilievip/cdi-jpa-jta-generic-dao.

Maybe it makes sense to keep this issue open? I see, for example, one can 
update @Transactional annotation from deltaspike to be JTA 1.2 compliant. There 
are many ways to get this done, my attempt is one of them.


was (Author: vasilievip):
I'm not sure why you closed this feature request because of issue in one 
proposed solution, but anyway: I compiled example on how to plug my patch into 
deltaspike w/o affecting its core deps: 
https://github.com/vasilievip/cdi-jpa-jta-generic-dao.

Maybe it makes sense to keep this issue open? I see foe example one can update 
@Transactional annotation from deltaspike to be JTA 1.2 compliant. There are 
many ways to get this done, my attempt is one of them.

> Add support for javax.transaction.Transactional annotation added in JTA 1.2 
> spec
> --------------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-473
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-473
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: Data-Module, JPA-Module, TestControl
>    Affects Versions: 0.6
>            Reporter: Ivan Vasyliev
>         Attachments: add_jta_1_2_into_deltaspike.patch
>
>
> https://www.youtube.com/watch?v=rChkWy2NFyQ
> The @Transactional annotation is already part of JavaEE, so there is no need 
> to have custom one. 
> The idea is to reuse code from JTA implementation. The one which  already 
> supports 1.2 is Jbosstm(Narayana). I've made an attempt to incorporate it 
> into deltaspike. Please see attached changes and testcase. 
> Few notes on it:
> - The producers for openwebbeans and weld are different, I've made 
> openwebbeans ones
> - There is 2 system preferences which needs to be set to make narayana create 
> system folders under proper location (see surefire plugin config)
> - Latest hibernate can autodetect JTA platform
> - EntityManager created outside of JTA transaction can't join it 
> automatically, thats why there is proxy which join EM into 
> (http://stackoverflow.com/questions/11119182/skipping-jta-sync-registration-due-to-auto-join-checking/11124021#11124021)
> - Code based on this examples: 
> https://github.com/jbosstm/quickstart/tree/master/ArjunaJTA/standalone-jta-1_2
> - I did not make attempt to create generic datasource registration function, 
> this maybe subject for other issue



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to