with that argument (that it is something different), we don't have to
rename other parts (because they are different anyway).

regards,
gerhard



2014-02-15 8:18 GMT+01:00 Mark Struberg <[email protected]>:

>
> Well, I do not get the reason at all.
>
> If someone could tell me the benefits of this move, then I'd be happy.
>
> From my pov it is not only unnecessary but really wrong.
> a.) changing the maven coordinates should always ONLY be done if there is
> a strong reason imo. Remember that the old artifact-ids are still on
> maven.central and will confuse users. We should really avoid GAV changes to
> not clutter up our project in maven.central.
>
> b.) CdiCtrl is really something completely different than ds-core and it's
> modules. I would also NOT move the test module under /modules but under an
> own top level directory. Plus the test module is not released yet, so we
> can rename it, move it, etc
>
> I just don't get any of the benefits we would get with renaming and moving
> CdiCtrl, thus I'm -1. There also have been no argument for it so far. A 'it
> looks different' does not count imo as it IS something different. If you
> like to have them look same then rename test-control to testCtrl...
>
> c.) while we are at it: originally I did craete a separate deltaspike
> directory because I thought that the site and documentation will be
> maintained inside our git repo. But with our CMS and the docs happening
> outside our source repo we  do not need it anymore. Thus should we move all
> the content from ./deltaspike/ to ./? This is something which really should
> be considered to be done before 1.0.
>
> LieGrue,
> strub

Reply via email to