i'll refactor it tomorrow. + i'll also replace @Initialized in the data-module (there we have the same as well).
regards, gerhard 2014-02-19 8:03 GMT+01:00 Christian Kaltepoth <christ...@kaltepoth.de>: > +1 > > > 2014-02-18 14:29 GMT+01:00 Thomas Andraschko <andraschko.tho...@gmail.com > >: > > > sounds good! > > > > > > 2014-02-18 14:19 GMT+01:00 Gerhard Petracek <gerhard.petra...@gmail.com > >: > > > > > @ thomas: > > > > > > @Observes @BeforeJsfRequest FacesContext > > > @Observes @AfterJsfRequest FacesContext > > > -> > > > @Observes @Initialized FacesContext > > > @Observes @Destroyed FacesContext > > > > > > the implementation of @AfterJsfRequest fits to @Destroyed, but for > > > @Initialized we might have to move the logic (to get a real > > initialization > > > event). > > > if we would move it to DeltaSpikeFacesContextFactory the benefit is > > > minimal, but there would be an overhead for resource-request and there > is > > > no active client-window at that point. > > > > > > regards, > > > gerhard > > > > > > > > > > > > 2014-02-18 13:44 GMT+01:00 Mark Struberg <strub...@yahoo.de>: > > > > > > > +1 > > > > > > > > LieGrue, > > > > strub > > > > > > > > > > > > > > > > > > > > > > > > On Tuesday, 18 February 2014, 13:27, Thomas Andraschko < > > > > andraschko.tho...@gmail.com> wrote: > > > > > > > > +1 > > > > >I like such minor improvements and finalize such stuff :) > > > > > > > > > >Whats the replacements for @After/BeforeJsfRequest then? > > > > > > > > > > > > > > > > > > > > > > > > >2014-02-18 13:23 GMT+01:00 Gerhard Petracek < > > gerhard.petra...@gmail.com > > > >: > > > > > > > > > >> hi @ all, > > > > >> > > > > >> if we would move @Initialized and @Destroyed to ds-core, we could > > use > > > > them > > > > >> for other parts as well (e.g. instead of @BeforeJsfRequest and > > > > >> @AfterJsfRequest). > > > > >> > > > > >> regards, > > > > >> gerhard > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > Christian Kaltepoth > Blog: http://blog.kaltepoth.de/ > Twitter: http://twitter.com/chkal > GitHub: https://github.com/chkal >
