[ 
https://issues.apache.org/jira/browse/DELTASPIKE-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494017#comment-14494017
 ] 

ASF GitHub Bot commented on DELTASPIKE-813:
-------------------------------------------

Github user rsmeral commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/27#discussion_r28320133
  
    --- Diff: documentation/src/main/asciidoc/core.adoc ---
    @@ -123,6 +124,29 @@ fields.
     BeanProvider.injectFields(myObject);
     ------------------------------------
     
    +===== DependentProvider
    +
    +`DependentProvider` must be used instead of `BeanProvider` to obtain 
instances of dependent-scoped beans to allow for
    +their proper destruction.
    +
    +When obtaining contextual instances using `@Inject`, the normal-scoped 
ones get destroyed along with their associated
    +context. However, instances of dependent-scoped beans -- as implied by 
their name -- depend on the lifecycle of
    +the contextual instance which declares them and get destroyed along with 
this declaring bean's instance.
    +
    +However, if dependent-scoped instances are obtained programmatically using 
`DependentProvider`, there's no
    +"declaring bean" to speak of and they *must be destroyed manually*.
    --- End diff --
    
    Not 100% sure about this, can someone confirm?


> improve basic core documentation
> --------------------------------
>
>                 Key: DELTASPIKE-813
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-813
>             Project: DeltaSpike
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 1.2.1
>            Reporter: Gerhard Petracek
>            Assignee: Rafael Benevides
>             Fix For: 1.3.1
>
>
> in this first step we should improve everything which is marked red or yellow 
> in the documentation column and green or yellow in the "importance for 
> average users" column ( see 
> https://cwiki.apache.org/confluence/display/DeltaSpike/DS-Core+Overview )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to