Hi!

Sorry for brevity. Like to quickly sum up what we discussed on irc:

.) DeltaSpikeConfig is merely a marker interface for interfaces/classes which 
can be used to define the behaviour of certain DeltaSpike features at runtimy. 
Since this is a class it can return different values for each invocation. This 
is e.g. useful for the LocaleResoler configuration (each user request could 
result in another Locale). Otoh this configuration mechanism is only available 
once the CDI container finally got booted. So it can NOT be used to e.g. 
configure CDI Extensions itself.

.) ConfigResolver based configuration. The TypeConfig is basically a object 
which contains the config-key + code to access the value. This mechanism is 
purely JavaSE and thus can also be used to configure Extensions itself as well. 
It’s also more the kind of a ’static’ configuration.

LieGrue,
strub


> Am 27.04.2015 um 19:38 schrieb Ron Smeral <rsme...@apache.org>:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Hi,
> 
> DeltaSpike itself is currently configured in at least 2 different ways:
> * using interfaces extending DeltaSpikeConfig:
> ** org.apache.deltaspike.jpa.api.transaction.TransactionConfig
> ** org.apache.deltaspike.jsf.api.config.JsfModuleConfig
> (** PropertyFileConfig (Why? It does not configure just DS itself.))
> 
> * using interfaces with static TypedConfig instances:
> ** org.apache.deltaspike.testcontrol.impl.jsf.MyFacesTestBaseConfig
> ** org.apache.deltaspike.testcontrol.api.junit.TestBaseConfig
> ** org.apache.deltaspike.scheduler.impl.SchedulerBaseConfig
> ** org.apache.deltaspike.jsf.api.config.base.JsfBaseConfig
> ** org.apache.deltaspike.core.api.config.base.CoreBaseConfig
> 
> My questions are:
> * why does PropertyFileConfig implement DeltaSpikeConfig? Doesn't make
> sense to me, given the purpose of DeltaSpikeConfig.
> 
> * is there any reason why the ones from the first category
> (TransactionConfig and JsfModuleConfig) couldn't be implemented using
> the second way (TypedConfig)?
> 
> * if none of the above is applicable, then: shouldn't the TypedConfig
> ones (CoreBaseConfig, ...) implement DeltaSpikeConfig as well?
> 
> I hacked up a quick suggestion of how this could look:
> https://github.com/rsmeral/deltaspike/commit/b5be1c79b67d6a15b30036ed90a
> 7b90fba9b5e00
> 
> Currently, having two ways of configuration defies the purpose of
> DeltaSpikeConfig -- that is allowing to find DS configuration points
> easily.
> 
> WDYT?
> 
> Regards,
> Ron
> 
> - -- 
> Ron Smeral
> JBoss Quality Engineer
> Red Hat
> Brno
> -----BEGIN PGP SIGNATURE-----
> 
> iQIcBAEBCgAGBQJVPnQmAAoJEJr1g28gQ1chzXQP/1FGjbYZlU80PsDPcjPROMEZ
> w5K/Rl/PTrHqzBsqnrFfN3qDVagXgGasRUKphV/r9Dk88G1+1I6ENWv2u6XZy8rh
> yat3kJmNsCJJvAzaq7I66vAk4kfTR+VNkKc1SdeaR/JgP4Iamyi9kF5cU7j4FMmY
> JngHT8qQJiS+Zli9f8l3FZ+1IzDVWAyBGoYgmrKJKpkc3bZiHpaFiXIrpWDzI3JA
> vJ8mlbz8SCpEUsd2/cZzAaO9MhUnI47j6cDMzQaLnriXkPeajU/GRB/h50cFjuYS
> smD0ezHdnrq1YMr5yk0rLNd2SXSXaMLESGuh6yg0kNqsQOtySS11ruyl4/b4rbXc
> deouS/eO0aokr4QgXJEenBKjQU6SZwswenuQvpEDpWjnQxtJRbnIIa9jvctjV3F0
> H72kWo8lxTZpCfWh2E55xGc8GfeLvYJoeAKtHwGzxISNB6u1IOJEwudr3KSqp1Ag
> 88aIy0CFM0dMjhm62785DOYmYbWHGbrxwMN0/2s2SYfWPq0jfVLxmBRE0L+EC7uZ
> 2JV26jpt9gD19EOl/qU9pO371mHdOUeTo5uXMnHDzX3q4cBFJGovVw0+tgyxGaEq
> B3X1nHt7QBMVNTYGvxanxy9xxVmwxUqqL76dUTFN7U3Q1kmIpg1sSV2hRwNYAEwk
> ZPVUbLjKwIPTEQbPbFXn
> =VGY0
> -----END PGP SIGNATURE-----

Reply via email to