@thomas: imo that's just the first step and we should define a simple api (+ move the rest to the impl. module).
regards, gerhard 2015-04-29 8:13 GMT+02:00 Thomas Andraschko <andraschko.tho...@gmail.com>: > Looks good but api without impl looks a little bit weird :) > > 2015-04-29 0:59 GMT+02:00 rafabene <g...@git.apache.org>: > > > Github user rafabene commented on a diff in the pull request: > > > > https://github.com/apache/deltaspike/pull/30#discussion_r29297290 > > > > --- Diff: deltaspike/modules/proxy-utils/api/pom.xml --- > > @@ -0,0 +1,86 @@ > > +<?xml version="1.0" encoding="UTF-8"?> > > +<!-- Licensed to the Apache Software Foundation (ASF) under one or > > more contributor > > + license agreements. See the NOTICE file distributed with this > work > > for additional > > + information regarding copyright ownership. The ASF licenses this > > file to > > + you under the Apache License, Version 2.0 (the "License"); you > may > > not use > > + this file except in compliance with the License. You may obtain a > > copy of > > + the License at http://www.apache.org/licenses/LICENSE-2.0 Unless > > required > > + by applicable law or agreed to in writing, software distributed > > under the > > + License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR > > CONDITIONS > > + OF ANY KIND, either express or implied. See the License for the > > specific > > + language governing permissions and limitations under the License. > > --> > > +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi=" > > http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation=" > > http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd > > "> > > + <modelVersion>4.0.0</modelVersion> > > + > > + <parent> > > + <groupId>org.apache.deltaspike.modules</groupId> > > + <artifactId>proxy-utils-module-project</artifactId> > > + <version>1.3.1-SNAPSHOT</version> > > + </parent> > > + > > + <artifactId>deltaspike-proxy-module-api</artifactId> > > + > > + <name>Apache DeltaSpike Proxy-Utils-Module API</name> > > + > > + <build> > > + <plugins> > > + <plugin> > > + <groupId>org.apache.maven.plugins</groupId> > > + <artifactId>maven-shade-plugin</artifactId> > > + <version>2.3</version> > > + <configuration> > > + > > <shadedArtifactAttached>false</shadedArtifactAttached> > > + > > <createDependencyReducedPom>false</createDependencyReducedPom> > > + > > <promoteTransitiveDependencies>true</promoteTransitiveDependencies> > > + <relocations> > > + <relocation> > > + <pattern>org.objectweb.asm</pattern> > > + > > <shadedPattern>org.apache.deltaspike.core.util.proxy.asm5</shadedPattern> > > --- End diff -- > > > > I'm not sure. Anyway, I think I should change this package. > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > > with INFRA. > > --- > > >
