HI Thomas, I'm very happy to announce that we don't have problem with https://issues.apache.org/jira/browse/DELTASPIKE-901, but I attached a patch with a new test in data-module.
Romain have a observation for data-module: <rmannibucau> soro, do you care testing against 1.3.0? <rmannibucau> but it really looks like my app <rmannibucau> which openjpa version? <rmannibucau> 2.4.0? <soro> rmannibucau, tomee 1.7.0 <rmannibucau> can be sthg fixed in openjpa 2.4 then <soro> Do you want that I test in DS 1.3.0? <soro> I can do it. NP. :) <rmannibucau> well my envrt was tomee 7 (openjpa 2.4) + ds 1.3.0 <rmannibucau> but i suspect more openjpa to have validated the query <rmannibucau> 1.7.0 uses a custom version <rmannibucau> pre-2.4 <soro> hmm <soro> rmannibucau, anyway, I'll push this patch. Sounds good? <rmannibucau> yep <rmannibucau> we should have the same kind of testing that for containers but for jpa only in ds-data <rmannibucau> even if embedded Romain, Do we need to open a new issue to your suggestion to put test for jpa only in ds-data? For this change, I don't know if necessary discuss about or simply doing it. :) On Fri, May 15, 2015 at 4:28 AM, Thomas Hug <[email protected]> wrote: > Wow, thnx for churning out those fixes! :) (and also to Rafael for > reviewing!) Will take some time for me to get to it but will try to do this > asap. > Cheers, > Thomas > > On Thu, May 14, 2015 at 10:17 PM, Daniel Cunha <[email protected]> > wrote: > > > Hi Thomas, > > > > I've working in some issues and I would like to send my result on work in > > DS. > > I have attached patch for: > > https://issues.apache.org/jira/browse/DELTASPIKE-603 > > https://issues.apache.org/jira/browse/DELTASPIKE-894 > > https://issues.apache.org/jira/browse/DELTASPIKE-701 > > https://issues.apache.org/jira/browse/DELTASPIKE-902 > > > > I had an help of the Rafael Benevides (rbenevides), he reviewed my patchs > > in (DELTASPIKE-894, DELTASPIKE-701). > > Let me know if the patchs is good or need improvement. I would like to > help > > more :) > > > > I'll start work on DELTASPIKE-901. > > See you. Thank you. > > > > On Wed, May 13, 2015 at 1:10 PM, Daniel Cunha <[email protected]> > > wrote: > > > > > Hi Thomas, > > > > > > I'm looking to DELTASPIKE-701 and DELTASPIKE-603 > > > I'm preparing to start with DELTASPIKE-603. Do you have something for > it > > > or did something? > > > I would like to fix it, if you don't have time to do. :) > > > > > > On Wed, May 13, 2015 at 1:00 PM, Thomas Hug <[email protected]> > > wrote: > > > > > >> Hi Daniel > > >> I definitely don't have as much time for DS as I'd like to have (right > > now > > >> close to none ;) so any help is welcome :). Let me know if you have > any > > >> specific issue in mind and we can check what's needed. > > >> Cheers, > > >> Thomas > > >> > > >> On Wed, May 13, 2015 at 12:13 AM, Daniel Cunha <[email protected]> > > >> wrote: > > >> > > >> > Hi Thomas, > > >> > > > >> > I can to see that we have some issues opened and not fixed if you > > want I > > >> > can try help you with this tasks. > > >> > Let me know if you need help to fix another issues in data-module. > :) > > >> > > > >> > On Mon, May 11, 2015 at 4:55 AM, Thomas Hug <[email protected]> > > >> wrote: > > >> > > > >> > > Hi Daniel > > >> > > > > >> > > Thanks for the patch! I should have some bandwidth the next week > to > > do > > >> > some > > >> > > DS coding and take care about it. > > >> > > There's indeed room for improvement for the criteria API. I was > not > > >> > really > > >> > > sure how useful people find it and started with a simplified > > version, > > >> but > > >> > > if it gets more adoption it's definitely worth filling the gaps. > > >> Feedback > > >> > > and PRs always welcome :) > > >> > > > > >> > > Cheers, > > >> > > Thomas > > >> > > > > >> > > On Fri, May 8, 2015 at 10:51 PM, Daniel Cunha < > [email protected] > > > > > >> > > wrote: > > >> > > > > >> > > > Hi folks, > > >> > > > > > >> > > > I started to change something in data-module, I don't know if we > > >> have > > >> > > time > > >> > > > to do it, but, let me know if DELTASPIKE-894 could be apply in > > next > > >> > > > release. > > >> > > > > > >> > > > We don't support all methods. Do we want support for all > methods? > > >> > > > I can to see that some methods like 'isTrue', 'isFalse', etc.. > of > > >> the > > >> > > > Criteria not is supported by DS data-module. > > >> > > > > > >> > > > -- > > >> > > > Best regard, > > >> > > > Daniel Cunha (soro) > > >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > -- > > >> > Best regard, > > >> > Daniel Cunha (soro) > > >> > > > >> > > > > > > > > > > > > -- > > > Best regard, > > > Daniel Cunha (soro) > > > > > > > > > > > -- > > Best regard, > > Daniel Cunha (soro) > > > -- Best regard, Daniel Cunha (soro)
