[
https://issues.apache.org/jira/browse/DELTASPIKE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579207#comment-14579207
]
ASF GitHub Bot commented on DELTASPIKE-594:
-------------------------------------------
GitHub user hwellmann opened a pull request:
https://github.com/apache/deltaspike/pull/39
DELTASPIKE-594 removed static singleton RepositoryComponents
This is now an application-scoped bean, thus fixing a potential
classloader leak when application is undeployed.
Had to remove RepositoryComponentsFactory.instance() API, which probably
shouldn't have been there in the first place. It was not used anywhere in DS.
Tested with -Pwildfly-remote.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hwellmann/deltaspike DELTASPIKE-594
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/deltaspike/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 9c022e2fecdb6c9cd2e25f6efb96d96ec6210dc8
Author: Harald Wellmann <[email protected]>
Date: 2015-06-09T16:52:38Z
DELTASPIKE-594 removed static singleton RepositoryComponents
This is now an application-scoped bean, thus fixing a potential
classloader leak when application is undeployed.
----
> Memory leak in RepositoryComponents singleton
> ---------------------------------------------
>
> Key: DELTASPIKE-594
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-594
> Project: DeltaSpike
> Issue Type: Bug
> Components: Data-Module
> Affects Versions: 0.7
> Reporter: Harald Wellmann
> Assignee: Harald Wellmann
>
> {{RepositoryComponentsFactory}} has a static singleton member of type
> {{RepositoryComponents}}.
> Repository classes are added to this singleton, but are never deleted.
> This will cause a classloader leak when the DeltaSpike modules live longer
> than application modules, e.g. in OSGi when each DeltaSpike module is a
> separate bundle, or in WildFly when DeltaSpike is installed as a JBoss module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
