[
https://issues.apache.org/jira/browse/DELTASPIKE-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634204#comment-14634204
]
Janario edited comment on DELTASPIKE-928 at 7/20/15 10:45 PM:
--------------------------------------------------------------
Sorry for the time, I was quite busy and couldn't test as far as I wanted
So, I've tested right now with the snapshot and it seems to be wrong evaluating:
windowhandler.js
if (dswh.utils.isHtml5() && dswh.cfg.storeWindowTree) {
dswh.cfg.storeWindowTree has a value as an string "false" but javascript is
evaluating it as has content(true)
As I've seen in WindowIdHtmlRenderer could change :
writer.write("'storeWindowTree':'" +
clientWindowConfig.isClientWindowStoreWindowTreeEnabled() + "'");
to
writer.write("'storeWindowTree':" +
clientWindowConfig.isClientWindowStoreWindowTreeEnabled());
or change in js to compare as string
was (Author: janario):
Sorry for the time, I was quite busy and couldn't test as far as I wanted
So, I've tested right now with the snapshot and it seems to be wrong evaluating:
windowhandler.js
if (dswh.utils.isHtml5() && dswh.cfg.storeWindowTree) {
dswh.cfg.storeWindowTree has a value as an string "false" but javascript is
evaluating it as has content(true)
As I've seen in WindowIdHtmlRenderer could change :
writer.write("'storeWindowTree':'" +
clientWindowConfig.isClientWindowStoreWindowTreeEnabled() + "'");
to
writer.write("'storeWindowTree':" +
clientWindowConfig.isClientWindowStoreWindowTreeEnabled() + "");
or change in js to compare as string
> Allow to disable storeWindowTree() on ClientWindow mode
> -------------------------------------------------------
>
> Key: DELTASPIKE-928
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-928
> Project: DeltaSpike
> Issue Type: Improvement
> Components: JSF-Module
> Affects Versions: 1.4.0
> Environment: JSF with clientWindow
> Reporter: Janario
> Assignee: Thomas Andraschko
> Fix For: 1.4.2
>
> Attachments: DELTASPIKE-928.patch
>
>
> If I change the default windowhandler.html, I may not want to reuse the
> client data storage and this leave some object there forever.
>
> It would be nice if I could disable that
> windowhandler.js (storeWindowTree())
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
