[ 
https://issues.apache.org/jira/browse/DELTASPIKE-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643025#comment-14643025
 ] 

Daniel Cunha (soro) commented on DELTASPIKE-965:
------------------------------------------------

It's weird, this method was created because before we had a problem with String 
ID.
If you can to see the deltaspike-dev list, Akm had this problem and we resolve 
in 1.4.2.

I saw your comments in GitHub and we can improve the method, really.
But, I tested it and work fine.

I put this new test:
https://github.com/danielsoro/deltaspike/commit/24d6f86cd3a19a656281e162979560e1a917f6ff

Please, add a test that fail in your repository, will be more easy to fix it.
Thank you [~hwellmann]

> EntityRepository.save() is broken for entities with String ID
> -------------------------------------------------------------
>
>                 Key: DELTASPIKE-965
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-965
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Data-Module
>    Affects Versions: 1.4.2
>            Reporter: Harald Wellmann
>            Priority: Blocker
>             Fix For: 1.4.3
>
>
> EntityRepository.save() generates illegal SQL when the entity identity is of 
> String type.
> This is a regression introduced in 1.4.2 with 
> {{org.apache.deltaspike.data.impl.handler.CdiQueryInvocationContext.countCheck(Object)}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to