[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953005#comment-14953005
 ] 

John D. Ament commented on DELTASPIKE-1001:
-------------------------------------------

[~gpetracek] Thanks for taking a look! Much appreciated.

Your test looks fine.  I didn't add something like this since we were already 
testing out this area.

The one downside to how I'm doing this is that you can't change project stage 
midflight.  If I look here, it doesn't seem to be noted that way: 
https://deltaspike.apache.org/documentation/projectstage.html.  Since that's 
the case I decided on this approach.

Do we know this to be an issue, where a project stage may be reported as one 
value early in booting, and a different one later in booting?

One issue I saw with the old code (which I don't think this is much different) 
is that the caching and calculating were all done by the utility.  By 
separating it out into classes we're clarifying the responsibility and behavior.

> Skip caching ClassDeactivation for some project stages
> ------------------------------------------------------
>
>                 Key: DELTASPIKE-1001
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1001
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.5.0
>            Reporter: John D. Ament
>            Assignee: John D. Ament
>             Fix For: 1.5.1
>
>
> Add the ability to skip caching if the project stage is unit test and 
> possibly development.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to