hi john, that just means an implementation needs to rely on it or needs additional concepts to handle it differently. DefaultEntityManagerHolder doesn't store it at all and the only useful implementation needed by the data-module stores it as a thread-local (see ThreadLocalEntityManagerHolder).
regards, gerhard 2015-11-27 14:47 GMT+01:00 John D. Ament <johndam...@apache.org>: > This requires entity manager to be serializable... Won't work. > On Nov 27, 2015 08:46, <gpetra...@apache.org> wrote: > > > Repository: deltaspike > > Updated Branches: > > refs/heads/master 7681a6d4d -> 74c0e3f84 > > > > > > DELTASPIKE-1034 ActiveEntityManagerHolder needs to be Serializable > > > > > > Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo > > Commit: > http://git-wip-us.apache.org/repos/asf/deltaspike/commit/74c0e3f8 > > Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/74c0e3f8 > > Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/74c0e3f8 > > > > Branch: refs/heads/master > > Commit: 74c0e3f8483e826398cc5f3491156db96b2f3b96 > > Parents: 7681a6d > > Author: gpetracek <gpetra...@apache.org> > > Authored: Fri Nov 27 14:41:03 2015 +0100 > > Committer: gpetracek <gpetra...@apache.org> > > Committed: Fri Nov 27 14:45:24 2015 +0100 > > > > ---------------------------------------------------------------------- > > .../jpa/spi/entitymanager/ActiveEntityManagerHolder.java | 5 > ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > ---------------------------------------------------------------------- > > > > > > > > > http://git-wip-us.apache.org/repos/asf/deltaspike/blob/74c0e3f8/deltaspike/modules/jpa/api/src/main/java/org/apache/deltaspike/jpa/spi/entitymanager/ActiveEntityManagerHolder.java > > ---------------------------------------------------------------------- > > diff --git > > > a/deltaspike/modules/jpa/api/src/main/java/org/apache/deltaspike/jpa/spi/entitymanager/ActiveEntityManagerHolder.java > > > b/deltaspike/modules/jpa/api/src/main/java/org/apache/deltaspike/jpa/spi/entitymanager/ActiveEntityManagerHolder.java > > index 19ee6a6..2d34582 100644 > > --- > > > a/deltaspike/modules/jpa/api/src/main/java/org/apache/deltaspike/jpa/spi/entitymanager/ActiveEntityManagerHolder.java > > +++ > > > b/deltaspike/modules/jpa/api/src/main/java/org/apache/deltaspike/jpa/spi/entitymanager/ActiveEntityManagerHolder.java > > @@ -19,15 +19,15 @@ > > package org.apache.deltaspike.jpa.spi.entitymanager; > > > > import javax.persistence.EntityManager; > > +import java.io.Serializable; > > > > /** > > * Optional holder which allows to customize the handling of the {@link > > EntityManager}. > > * Multiple Entity-Managers with different qualifiers aren't supported. > > * See the data-module for further details. > > */ > > -public interface ActiveEntityManagerHolder > > +public interface ActiveEntityManagerHolder extends Serializable > > { > > - > > void set(EntityManager entityManager); > > > > boolean isSet(); > > @@ -35,5 +35,4 @@ public interface ActiveEntityManagerHolder > > EntityManager get(); > > > > void dispose(); > > - > > } > > > > >
