[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262050#comment-15262050
 ] 

ASF GitHub Bot commented on DELTASPIKE-1137:
--------------------------------------------

GitHub user manovotn opened a pull request:

    https://github.com/apache/deltaspike/pull/47

    DELTASPIKE-1137, created separate profiles for Weld versions, changed…

    … docs accordingly.
    
    I created 3 separate profiles for Weld 1/2/3 respectively.
    As all three profiles have part of their build management/dependencies in 
common, I took those out and put them into a separate profile 
(`Weld-common-setup`).
    
    `Weld-common-setup` is automatically triggered when you use 
`-Dweld.version=...` when executing tests (which you do like...all the time? :) 
). I couldn't really come up with other solution which would allow to avoid 
copying this setup into all three profiles. The downside of this is that once 
you run the tests without `-Dweld.version`, it will not work.
    
    Last but not least, I modified docs (`build.adoc` to be more precise) to 
reflect these changes.
    
    Ideas/comments are welcome!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manovotn/deltaspike weldProfileRefactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/deltaspike/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit ae16e7a4c6a3303657fe657c059a5a7da7a9ebbf
Author: Matej Novotny <[email protected]>
Date:   2016-04-28T12:15:36Z

    DELTASPIKE-1137, created separate profiles for Weld versions, changed docs 
accordingly.

----


> core/impl test suite freezes in embedded container with Weld 1.x
> ----------------------------------------------------------------
>
>                 Key: DELTASPIKE-1137
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1137
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.6.1
>         Environment: Embedded container
> Weld 1.x
>            Reporter: Matej Novotny
>
> According to DS 
> [documentation|https://deltaspike.apache.org/documentation/build.html], the 
> basic way to build DS with Weld should be by running {{$ mvn clean install 
> -PWeld}}.
> Running this will indeed start the build but will then freeze mid-way through 
> with no response/failure. For me, the last (successfully) executed test was 
> {{org.apache.deltaspike.test.core.impl.resourceloader.ClasspathResourceTest}} 
> and then it just froze, doing nothing untill killed.
> The build always freezes on {{deltaspike/core/impl}} tests. So the fastest 
> way to reproduce it to run the command from there.
> The above written command will, by default, use (an outdated) version 
> 1.1.28.Final of Weld.
> To use more up to date version, one can add something like this - 
> {{-Dweld.version=1.1.33.Final}}. Anyway, version makes no difference here, it 
> still freezes.
> The tests are executed within embedded container.
> NOTE: This only affects Weld 1.x, using Weld 2.x or 3.x works perfectly fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to