[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268672#comment-15268672
 ] 

ASF GitHub Bot commented on DELTASPIKE-1091:
--------------------------------------------

Github user manovotn commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/49#discussion_r61877744
  
    --- Diff: deltaspike/parent/pom.xml ---
    @@ -49,7 +49,8 @@
         <properties>
             <java.version>1.6</java.version>
             <owb.version>1.2.7</owb.version>
    -        <weld.version>1.1.28.Final</weld.version>
    +        <!-- Weld profiles (in parent/code/pom.xml) override this version 
-->
    +        <weld.version>1.1.9.Final</weld.version>
    --- End diff --
    
    This is based on a Gerhard's comment. He claimed that the idea is to list 
the minimal supported version. Although I strongly dislike dislike this 
approach, I put it here.
    However if you look into Weld1 profile, you can see it is overriden by 
current version (1.1.33.Final). So this version declaration is naught but a 
mere information :)


> Weld core BOM update in next 2.3/3.x release
> --------------------------------------------
>
>                 Key: DELTASPIKE-1091
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1091
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Matej Novotny
>            Assignee: Rafael Benevides
>
> The next release of Weld 2.3 (2.3.4.Final) and 3.x (3.0.Alpha16) will also 
> contain a refactored weld-core BOM files.
> This is per request in [WELD-2115|https://issues.jboss.org/browse/WELD-2115].
> BOM will no longer provide direct dependencies, but only 
> {{dependencyManagement}} section. Looking at deltaspike dependencies, this 
> will affect 
> [{{parent/code/pom.xml}}|https://github.com/apache/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L355]
>  and will require changes.
> The PRs for BOM changes are:
> * 2.3 branch -> https://github.com/weld/core/pull/1295
> * master -> https://github.com/weld/core/pull/1296



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to