On Mon, May 9, 2016 at 7:24 AM Mark Struberg <[email protected]>
wrote:
> a.)DeltaSpikeProxyFactory totally misses docs it sems. Or did I miss
> something?
>
The current docs are a step up from about two months ago when the only
thing on the doc page was "TODO: Document the proxy module" or something
along those lines.
Yes, there's still stuff missing.
>
> b.) there are methods which are imo questionable, e.g.
>
> public <T> Class<T> getProxyClass(BeanManager beanManager, Class<T>
> targetClass)
> {
> return getProxyClass(beanManager, targetClass,
> DummyInvocationHandler.class);
> }
>
>
> what do we need this for? Can I simply remove it?
> The DummyInvocationHandler just returns null. Without calling the proxied
> instance. It's basically a no-op impl. Why do we need this?
>
This smells like a strangle that wasn't completed. I'd say if it can be
delegated down, lets remove it. Better is if its only used in tests.
>
>
> c.) The ordering of the methods are mixed. Imo all public methods should
> be on top, protected and private at the bottom. Really hard to read atm.
>
+1
>
> Any thoughts?
>
> LieGrue,
> strub
>
