[
https://issues.apache.org/jira/browse/DELTASPIKE-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289485#comment-15289485
]
Bernhard Hablesreiter commented on DELTASPIKE-1144:
---------------------------------------------------
Ok- just built everything from scratch and tested again, seems to be fine now!
Sorry, might have been a browser-caching problem.
One issue might be, if I open a link in a new tab, then two redirects happen,
e.g.:
GET test
GET test?dsrid=590
GET test?dswid=-3402&dsrid=716
Maybe there is a way to limit the redirects to one.
There are two other issues we are currently investigating, but we will open a
new ticket if necessary:
- the ctrl+click does not open a new tab (only "open in new tab"), which could
probably be handled in the windowhandler.js (e.g. by checking the pressed key).
- all external urls are also handled by the windowhandler.js, even if they are
set as target="_blank", maybe there is also room for improvement.
> Existing window name may lead to infinite redirects
> ---------------------------------------------------
>
> Key: DELTASPIKE-1144
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1144
> Project: DeltaSpike
> Issue Type: Bug
> Components: JSF-Module
> Affects Versions: 1.6.1
> Reporter: Bernhard Hablesreiter
> Assignee: Thomas Andraschko
> Fix For: 1.6.2
>
>
> If the current browser tab already has a window name set and if one is
> navigating to an application running deltaspike JSF-module (LAZY mode), the
> existing window name may lead to infinite redirects in some situations.
> We encountered this problem last week when we were navigating from the
> website of an Austrian computer retailer to one of our applications (one
> example here:
> https://www.cyberport.at/lenovo-thinkpad-x1-carbon-notebook-i7-6500u-full-hd-matt-ssd-lte-windows-7-pro-1C30-46G_1695.html).
> It seems that this window name (in this example "iPad%3B CPU OS 5_") is
> causing the windowhandler.js to perform infinite redirects.
> Another example is if you're coming from netflix, the window id is always
> "dswid=_nflx" - although without redirects, but two tabs might share the same
> window context.
> One solution might be to check if the window name meets all requirements to
> be used as the window id (e.g. check if it is numeric) and if not to reset
> the window name and generate a new window id (just like if no window name is
> set).
> We also encountered a similiar problem in clientwindow mode when a link with
> parameters is clicked (get-request). In these situations the browser is also
> performing infinite redirects and streaming the windowhandler html file over
> and over again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)