I pushed up a branch to review the commit on. https://github.com/johnament/deltaspike/commit/25b0789539c4e45c426937824e448beb4f7aa931
There's a couple of bugs I see still, but this is mostly to get the gist of what I'm thinking for this extra module. This is very much akin to what we do with the test-ee7 module. - John On Sat, Jun 4, 2016 at 4:56 PM John D. Ament <[email protected]> wrote: > All, > > I wanted to get opinions before pushing this. I introduced Optional > support recently, and have Stream support working locally. Neither is > fully tested currently. I created a separate Java 8 test module to test > these Java 8 features. It's only active if the JDK being run in Maven is > Java 8. > > I was wondering if anyone had any concerns with introducing this test > module? I'm not comfortable pushing up these changes in the release > without tests, but know that Java 8 support is likely a concern. Here's a > snippet of what I added to the pom.xml for data: > > <profile> > <id>java8.tests</id> > <activation> > <jdk>1.8</jdk> > </activation> > <modules> > <module>test-java8</module> > </modules> > </profile> > > And what the repo looks like: > > @Repository(forEntity = Simple.class) > public interface SimpleRepository > { > Stream<Simple> findByName(String name); > > Optional<Simple> findOptional(Long id); > } > > Note: IntellIJ does report a warning since those are APIs introduced after > Java 6, but test do still run in the IDE. Note that the pom.xml doesn't > require Java 8, here's a gist of it: > https://gist.github.com/johnament/799bfb87ce6ad3f227a7a4aa7bd55153 > > I've tested it locally with JAVA_HOME pointing to both a Java 7 and a Java > 8 install to ensure things were working as expected. > > John >
