[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391034#comment-15391034
 ] 

ASF GitHub Bot commented on DELTASPIKE-1176:
--------------------------------------------

Github user johnament commented on a diff in the pull request:

    https://github.com/apache/deltaspike/pull/60#discussion_r71987310
  
    --- Diff: 
deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/future/DefaultFutureableStrategy.java
 ---
    @@ -202,6 +203,13 @@ public Object call() throws Exception
             };
     
             final ExecutorService pool = getOrCreatePool(ic);
    +        
    +        if (void.class.isAssignableFrom(returnType))
    --- End diff --
    
    Should we also check for `Void` in addition to `void`?


> Support void methods in Futureable
> ----------------------------------
>
>                 Key: DELTASPIKE-1176
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1176
>             Project: DeltaSpike
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.7.0
>            Reporter: John D. Ament
>            Assignee: Romain Manni-Bucau
>             Fix For: 1.7.2
>
>
> https://lists.apache.org/thread.html/73efae4ef5b2462af7165d5cb233557b8f97393355c8edb704eff53f@%3Cusers.deltaspike.apache.org%3E
>  for more context
> It appears that if a method returns void it cannot be used with the 
> Futureable interceptor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to