GitHub user famod opened a pull request:

    https://github.com/apache/deltaspike/pull/66

    DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()

    Ok, this fix enables the transfer of a exception thrown by the MBean method 
to the client.
    Tomorrow I'm going to update the JIRA ticket with some output examples.
    
    Not sure about the logging removal, though. In my project we have a logging 
interceptor for MBeans which logs exceptions anyway so another log entry from 
DynamicMBeanWrapper just "pollutes" the logfile.
    Exceptions aren't swallowed either, so ...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/famod/deltaspike DELTASPIKE-1207

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/deltaspike/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit 0bd61f2fa4d2c08b7554d5f2826b9c99cad8e7a6
Author: famod <f.mod...@gmx.net>
Date:   2016-10-16T20:17:47Z

    DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()

commit 6252c3998756b1f2eb6e0835c9583ec489f88cd6
Author: famod <f.mod...@gmx.net>
Date:   2016-10-16T20:28:29Z

    DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
    
    fix tabs

commit d19e47b0b9252b046e7e1a82be0ba6b7608f5e07
Author: famod <f.mod...@gmx.net>
Date:   2016-10-16T20:55:18Z

    DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
    
    remove unnecessary cast to Exception

commit 717f6fd08aaa38089002d0832da3a01529474bb1
Author: famod <f.mod...@gmx.net>
Date:   2016-10-16T21:24:49Z

    DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
    
    cause needs to be passed to MBeanException constructor, not e (and so
    casting is needed after all)

commit d341dc8f0900054c5e7f46d1833ede749c0c597f
Author: famod <f.mod...@gmx.net>
Date:   2016-10-18T21:40:24Z

    DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke()
    
    - don't wrap MBeanException directly thrown by the MBean method
    - document exception handling in @JmxManaged

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to