We can look at it later, its not blocking for now. I created https://issues.apache.org/jira/browse/DELTASPIKE-1257 to track.
On Sun, May 28, 2017 at 11:36 AM Mark Struberg <[email protected]> wrote: > The error I got was something else. This happened even with the > distribution profile. > Maven complained that the bom pom points to an illegal parent pom > (warning) and kept complaining about 'unresolved snaphots left' asking me > to specify the version for the various deltaspike modules. > > Maybe this only happens with more recent Maven versions, don't know... > In any case, if a pom is part of the reactor, then it should also > reference back to the build chain somehow. > > LieGrue, > strub > > > > Am 28.05.2017 um 17:24 schrieb John D. Ament <[email protected]>: > > > > I think that was the goal of the requestor's ask: > > > > - Not provide a bad bom > > - Only bring in our stuff > > > > DeltaSpike is very odd in the landscape, we don't directly declare > > dependencies. That's what makes a bom like this very useful and easy to > > manage, it doesn't bring in anything else. What would happen previously > is > > with the parent structure it would actually bring in our profiles and > some > > of the dependencies within those profiles. That doesn't happen with the > > structure I had put in place + dependency management section. With > this, a > > user ends up getting our internal build profiles, which may not match > what > > they're expecting to do. > > > > And I disagree about this breaking maven. The release failed because you > > didn't use the release profiles that have been mentioned since > > ~0.3-incubating. I've done it before as well and ended up with similar > > results, but I was able to catch it before throwing the vote (however, I > > missed that the binary dist was empty :-D) > > > > John > > > > On Sun, May 28, 2017 at 10:36 AM Romain Manni-Bucau < > [email protected]> > > wrote: > > > >> I'm kind of sharing Mark's feedback, each time I tried to use it > >> (arquillian, spring, ...) it just had a very bad user experience after > the > >> first manually added dependency so not sure it does worth all the tricks > >> the build would require or if we even really want to propose it to end > >> users. > >> > >> > >> Romain Manni-Bucau > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> <https://blog-rmannibucau.rhcloud.com> | Old Blog > >> <http://rmannibucau.wordpress.com> | Github < > >> https://github.com/rmannibucau> | > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > >> <https://javaeefactory-rmannibucau.rhcloud.com> > >> > >> 2017-05-28 16:33 GMT+02:00 Mark Struberg <[email protected]>: > >> > >>> Except that it broke Maven. > >>> > >>> In general I find this bom very questionable. > >>> Why would one use that? > >>> > >>> Usually boms get created as 'mashup' project to combine different > >>> separately released artifacts > >>> And there almost exclusively to pin down the versions of those various > >>> artifacts. > >>> > >>> So why would one import a bom instead of just writing > >>> > >>> <version>${deltaspike.version}</version > >>> > >>> ? > >>> > >>> Also the boms are really error prone. They ONLY work in the exact pom > you > >>> declare them in. > >>> So if you import the bom in your parent project and then reference the > >>> various deltaspike modules only in some specific parts of your build > then > >>> it doesn't work anyway. It's just not worth it! > >>> > >>> LieGrue, > >>> strub > >>> > >>>> Am 28.05.2017 um 14:54 schrieb John D. Ament <[email protected]>: > >>>> > >>>> Mark, > >>>> > >>>> On Sun, May 28, 2017 at 6:37 AM <[email protected]> wrote: > >>>> > >>>>> Repository: deltaspike > >>>>> Updated Branches: > >>>>> refs/heads/master 6721ca6ec -> a62a93fca > >>>>> > >>>>> > >>>>> further release fixes > >>>>> > >>>>> > >>>>> Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo > >>>>> Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/ > >>> 3ab179f6 > >>>>> Tree: > http://git-wip-us.apache.org/repos/asf/deltaspike/tree/3ab179f6 > >>>>> Diff: > http://git-wip-us.apache.org/repos/asf/deltaspike/diff/3ab179f6 > >>>>> > >>>>> Branch: refs/heads/master > >>>>> Commit: 3ab179f6bc469b16fb211775bacbee93b1eebdf5 > >>>>> Parents: 6721ca6 > >>>>> Author: Mark Struberg <[email protected]> > >>>>> Authored: Sun May 28 11:04:05 2017 +0200 > >>>>> Committer: Mark Struberg <[email protected]> > >>>>> Committed: Sun May 28 11:09:26 2017 +0200 > >>>>> > >>>>> > ---------------------------------------------------------------------- > >>>>> deltaspike/cdictrl/pom.xml | 12 ++++++++++++ > >>>>> deltaspike/dist/bom/pom.xml | 6 +++--- > >>>>> deltaspike/dist/full/pom.xml | 32 ++------------------------------ > >>>>> 3 files changed, 17 insertions(+), 33 deletions(-) > >>>>> > ---------------------------------------------------------------------- > >>>>> > >>>>> > >>>>> > >>>>> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/ > >>> 3ab179f6/deltaspike/cdictrl/pom.xml > >>>>> > ---------------------------------------------------------------------- > >>>>> diff --git a/deltaspike/cdictrl/pom.xml b/deltaspike/cdictrl/pom.xml > >>>>> index ece910f..bb9287d 100644 > >>>>> --- a/deltaspike/cdictrl/pom.xml > >>>>> +++ b/deltaspike/cdictrl/pom.xml > >>>>> @@ -93,6 +93,18 @@ > >>>>> </profile> > >>>>> > >>>>> <profile> > >>>>> + <id>apache-release</id> > >>>>> + > >>>>> + <modules> > >>>>> + <module>api</module> > >>>>> + <module>impl-owb</module> > >>>>> + <module>impl-weld</module> > >>>>> + <module>impl-openejb</module> > >>>>> + <module>servlet</module> > >>>>> + <module>tck</module> > >>>>> + </modules> > >>>>> + </profile> > >>>>> + <profile> > >>>>> <id>distribution</id> > >>>>> > >>>>> <modules> > >>>>> > >>>>> > >>>>> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/ > >>> 3ab179f6/deltaspike/dist/bom/pom.xml > >>>>> > ---------------------------------------------------------------------- > >>>>> diff --git a/deltaspike/dist/bom/pom.xml > b/deltaspike/dist/bom/pom.xml > >>>>> index dfae97f..090a129 100644 > >>>>> --- a/deltaspike/dist/bom/pom.xml > >>>>> +++ b/deltaspike/dist/bom/pom.xml > >>>>> @@ -21,9 +21,9 @@ > >>>>> <modelVersion>4.0.0</modelVersion> > >>>>> > >>>>> <parent> > >>>>> - <groupId>org.apache</groupId> > >>>>> - <artifactId>apache</artifactId> > >>>>> - <version>18</version> > >>>>> + <groupId>org.apache.deltaspike.distribution</groupId> > >>>>> + <artifactId>distributions-project</artifactId> > >>>>> + <version>1.8.0-SNAPSHOT</version> > >>>>> </parent> > >>>>> > >>>>> > >>>> This was a change explicitly requested in > >>>> https://issues.apache.org/jira/browse/DELTASPIKE-1088 , with this > >> setup > >>>> we're now including the transitive dependencies in the BOM. > >>>> > >>>> > >>>>> <groupId>org.apache.deltaspike.distribution</groupId> > >>>>> > >>>>> > >>>>> http://git-wip-us.apache.org/repos/asf/deltaspike/blob/ > >>> 3ab179f6/deltaspike/dist/full/pom.xml > >>>>> > ---------------------------------------------------------------------- > >>>>> diff --git a/deltaspike/dist/full/pom.xml > >> b/deltaspike/dist/full/pom.xml > >>>>> index 0b3d6f0..1467c68 100644 > >>>>> --- a/deltaspike/dist/full/pom.xml > >>>>> +++ b/deltaspike/dist/full/pom.xml > >>>>> @@ -21,8 +21,8 @@ > >>>>> <modelVersion>4.0.0</modelVersion> > >>>>> > >>>>> <parent> > >>>>> - <groupId>org.apache.deltaspike.distribution</groupId> > >>>>> - <artifactId>distributions-project</artifactId> > >>>>> + <groupId>org.apache.deltaspike.distribution</groupId> > >>>>> + <artifactId>distributions-project</artifactId> > >>>>> <version>1.8.0-SNAPSHOT</version> > >>>>> </parent> > >>>>> > >>>>> @@ -38,90 +38,77 @@ > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.core</groupId> > >>>>> <artifactId>deltaspike-core-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.core</groupId> > >>>>> <artifactId>deltaspike-core-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-security-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-security-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-jpa-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-jpa-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-servlet-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-servlet-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-jsf-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-jsf-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-jsf-module-impl-ee6</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-data-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-data-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> @@ -129,104 +116,89 @@ > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.cdictrl</groupId> > >>>>> <artifactId>deltaspike-cdictrl-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.cdictrl</groupId> > >>>>> <artifactId>deltaspike-cdictrl-owb</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.cdictrl</groupId> > >>>>> <artifactId>deltaspike-cdictrl-weld</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.cdictrl</groupId> > >>>>> <artifactId>deltaspike-cdictrl-openejb</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.cdictrl</groupId> > >>>>> <artifactId>deltaspike-cdictrl-servlet</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> > >> <artifactId>deltaspike-partial-bean-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-partial-bean-module-impl</ > >>> artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> > >> <artifactId>deltaspike-test-control-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-test-control-module-impl</ > >>> artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-bean-validation-module-api</ > >>> artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> > >>>>> <artifactId>deltaspike-bean-validation-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-scheduler-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-scheduler-module-impl</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-proxy-module-api</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>compile</scope> > >>>>> </dependency> > >>>>> > >>>>> <dependency> > >>>>> <groupId>org.apache.deltaspike.modules</groupId> > >>>>> <artifactId>deltaspike-proxy-module-impl-asm5</artifactId> > >>>>> - <version>${project.version}</version> > >>>>> <scope>runtime</scope> > >>>>> </dependency> > >>>>> </dependencies> > >>> > >>> > >> > >
