[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695631#comment-16695631
 ] 

Jörg Sesterhenn commented on DELTASPIKE-1356:
---------------------------------------------

[~struberg]: This is NOT fixed in the latest snapshot.

You need to make sure that your BOM does NOT have a parent (or grandparent, or 
any predecessor) with *dependency-management* since that is inherited!

There is nothing weird about it.

You managed that in 1.8.2 by simply setting the parent to
{code:java}
<parent>
  <groupId>org.apache</groupId>
  <artifactId>apache</artifactId>
  <version>18</version>
</parent>{code}
Compare

[http://central.maven.org/maven2/org/apache/deltaspike/distribution/distributions-bom/1.8.2/distributions-bom-1.8.2.pom]

[https://repository.apache.org/content/groups/snapshots/org/apache/deltaspike/distribution/distributions-bom/1.9.1-SNAPSHOT/distributions-bom-1.9.1-20181115.140125-71.pom]

The parent is currently
{code:java}
<parent>
  <groupId>org.apache.deltaspike.distribution</groupId>
  <artifactId>distributions-project</artifactId>
  <version>1.9.1-SNAPSHOT</version>
</parent>
{code}
Please fix your build so that the BOM is usable again.

> BOM imports more dependencies than it should
> --------------------------------------------
>
>                 Key: DELTASPIKE-1356
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1356
>             Project: DeltaSpike
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>         Environment: Maven 3.5.4
>            Reporter: Michael Düsterhus
>            Assignee: Mark Struberg
>            Priority: Major
>             Fix For: 1.9.1
>
>
> This is a regression from 1.8.2 were the BOM was fixed again.
> The parent of the pom points to other poms that define additional 
> dependencies.
> When I look at the effective pom I get these extra defintions from you bom 
> import:
> {code:java}
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-atinject_1.0_spec</artifactId>
> <version>1.0</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-ejb_3.1_spec</artifactId>
> <version>1.0.2</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-jcdi_1.0_spec</artifactId>
> <version>1.0</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-interceptor_1.1_spec</artifactId>
> <version>1.0</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.openwebbeans</groupId>
> <artifactId>openwebbeans-impl</artifactId>
> <version>1.2.8</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.openwebbeans</groupId>
> <artifactId>openwebbeans-spi</artifactId>
> <version>1.2.8</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.openwebbeans</groupId>
> <artifactId>openwebbeans-resource</artifactId>
> <version>1.2.8</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.openwebbeans</groupId>
> <artifactId>openwebbeans-web</artifactId>
> <version>1.2.8</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.openwebbeans</groupId>
> <artifactId>openwebbeans-jsf</artifactId>
> <version>1.2.8</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-servlet_3.0_spec</artifactId>
> <version>1.0</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-el_2.2_spec</artifactId>
> <version>1.0.3</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-validation_1.0_spec</artifactId>
> <version>1.1</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-jpa_2.0_spec</artifactId>
> <version>1.1</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-jta_1.1_spec</artifactId>
> <version>1.1.1</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.hamcrest</groupId>
> <artifactId>hamcrest-library</artifactId>
> <version>1.3</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-servlet_2.5_spec</artifactId>
> <version>1.2</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.openejb</groupId>
> <artifactId>arquillian-tomee-remote</artifactId>
> <version>1.7.0</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.tomee</groupId>
> <artifactId>arquillian-tomee-remote</artifactId>
> <version>1.7.0</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>javassist</groupId>
> <artifactId>javassist</artifactId>
> <version>3.12.0.GA</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.hibernate</groupId>
> <artifactId>hibernate-validator</artifactId>
> <version>4.3.1.Final</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.bval</groupId>
> <artifactId>bval-jsr303</artifactId>
> <version>0.5</version>
> <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.myfaces.core</groupId>
> <artifactId>myfaces-api</artifactId>
> <version>2.2.3</version>
> <scope>provided</scope>
> <exclusions>
> <exclusion>
> <artifactId>geronimo-jcdi_1.0_spec</artifactId>
> <groupId>org.apache.geronimo.specs</groupId>
> </exclusion>
> </exclusions>
> </dependency>
> <dependency>
> <groupId>org.apache.myfaces.core</groupId>
> <artifactId>myfaces-impl</artifactId>
> <version>2.2.3</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.myfaces.core</groupId>
> <artifactId>myfaces-impl-test</artifactId>
> <version>2.2.3</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.myfaces.test</groupId>
> <artifactId>myfaces-test20</artifactId>
> <version>1.0.6</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>commons-logging</groupId>
> <artifactId>commons-logging</artifactId>
> <version>1.1.1</version>
> <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.mockito</groupId>
> <artifactId>mockito-all</artifactId>
> <version>1.9.5</version>
> <scope>test</scope>
> </dependency>
> {code}
> My suggestion is to change 
> org.apache.deltaspike.distribution:distributions-project as parent to 
> org.apache.deltaspike:deltaspike
> It should be no problem if a module does not point to the parent it is 
> defined in.
> To reproduce just create a pom with the deltaspike import in 
> dependencyManagement section and show the effective pom.
> {code:java}
> <dependency>
> <groupId>org.apache.deltaspike.distribution</groupId>
> <artifactId>distributions-bom</artifactId>
> <version>${version.deltaspike}</version>
> <type>pom</type>
> <scope>import</scope>
> </dependency>
> {code}
> I do not understand where all these dependencies are coming from, because 
> some of them are defined in profiles that should not be considered during bom 
> import, perhaps this is also a maven bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to