[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123867#comment-17123867
 ] 

Mark Struberg commented on DELTASPIKE-1402:
-------------------------------------------

[~romain.manni-bucau] For disabling reload you can set {{deltaspike_reload=-1}} 
inside the property file. On almost every box the file metadata is heavily 
cached. So checking the lastModified is very cheap anyway. I've done quite a 
few perf tests on Linux, OSX and Win. All look fine.

> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during 
> runtime
> --------------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-1402
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
>             Project: DeltaSpike
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Configuration
>    Affects Versions: 1.9.3
>            Reporter: Mark Struberg
>            Priority: Major
>             Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via 
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
>  does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes 
> in this file.
> The same is true for other 
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most 
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk 
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the 
> last-changed timestamp of the file and only checked every minute or so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to