rmannibucau commented on a change in pull request #109:
URL: https://github.com/apache/deltaspike/pull/109#discussion_r720517626
##########
File path:
deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/config/TypedResolverImpl.java
##########
@@ -504,6 +530,66 @@ else if (Double.class.equals(configEntryType))
{
result = Double.parseDouble(value);
}
+ else if (Character.class.equals(configEntryType))
Review comment:
think we must take care of the packages, we likely don't want awt
package to be loaded there because there is a security manager or javaagent for
example.
think it can be better to provide the classes and enable to provide a
Map<Class<?>, Converter<?>> to the resolver.
by default - for implicit resolvers - we can try to load all the ones we
support - even if it should be per package group likely to avoid to fail 4
times when once is enough?. This default loading should likely be done in the
config extension or something like that and cached to be reused/reusable (if
the extension is injected). Manual resolvers can be loaded without any
additional converter (primitives/wrappers being the one we must support OOTB
only IMHO).
Side note: for the story behind this way to do, we did the exact same thing
in xbean with its converts == load them all by default, but in practise it is
very bothering and letting them be configurable and loaded at demand only is
way more relevant on user land in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
