SethFalco commented on code in PR #109:
URL: https://github.com/apache/deltaspike/pull/109#discussion_r1474853018
##########
deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/config/TypedResolverImpl.java:
##########
@@ -504,6 +530,66 @@ else if (Double.class.equals(configEntryType))
{
result = Double.parseDouble(value);
}
+ else if (Character.class.equals(configEntryType))
Review Comment:
Only took me 2.5 years to come back to this. ^-^'
In general, this makes sense. I'm currently trying to set up DeltaSpike
v2.0.0-SNAPSHOT for development, so I can clean this up and finally get it in a
state it can be merged. I've encountered an issue that I wanted to ask about,
though.
In a sandbox project, it looks like OpenWebBeans is trying to find and
inject a `java.util.regex.Pattern`, rather than leaving it for the DeltaSpike
Configuration module to handle. 🤔
I don't see any immediate issues with how things are set up, though. Sorry
to ask, but are you aware of any breaking changes that may prevent this from
working:
https://gist.github.com/SethFalco/82e16523963880c609b3a9b09ac6fd67
Meanwhile, I've rebased and fixed CI issues. 👍🏽
##########
deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/config/TypedResolverImpl.java:
##########
@@ -504,6 +530,66 @@ else if (Double.class.equals(configEntryType))
{
result = Double.parseDouble(value);
}
+ else if (Character.class.equals(configEntryType))
Review Comment:
Only took me 2.5 years to come back to this. ^-^'
In general, this makes sense. I'm currently trying to set up DeltaSpike
v2.0.0-SNAPSHOT for development, so I can clean this up and finally get it in a
state it can be merged. I've encountered an issue that I wanted to ask about,
though.
In a sandbox project, it looks like OpenWebBeans is trying to find and
inject a `java.util.regex.Pattern`, rather than leaving it for the DeltaSpike
Configuration module to handle. 🤔
I don't see any immediate issues with how things are set up, though. Sorry
to ask, but are you aware of any breaking changes that may prevent this from
working:
https://gist.github.com/SethFalco/82e16523963880c609b3a9b09ac6fd67
Meanwhile, I've rebased and fixed issues raised by CI. 👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
