Re: [PR] Wildfly-31 wildfly-build-managed - BeansXmlUtil.discovery-mode=all - mostly working [deltaspike]

[via GitHub]

shadogray commented on code in PR #151:
URL: https://github.com/apache/deltaspike/pull/151#discussion_r1501909719


##########
deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/injection/uc004/MyBeanValidator.java:
##########
@@ -26,15 +26,17 @@
 import jakarta.faces.validator.Validator;
 import jakarta.faces.validator.ValidatorException;
 import jakarta.inject.Inject;
+import jakarta.inject.Named;
 
-@FacesValidator("myBeanValidator")
+@Named
+@FacesValidator(value = "myBeanValidator", managed = true)
 public class MyBeanValidator implements Validator, StateHolder
 {
 
     @Inject
     private MyBean myBean;
 
-    private String validValue = "Apache";
+    private String validValue = "DeltaSpike";

Review Comment:
   All tests sent "DeltaSpike" as OK value:
   ```
   
src/test/java/org/apache/deltaspike/test/jsf/impl/injection/uc001/InjectionDroneTest.java:
        convertedValue.sendKeys("DeltaSpike");
   
src/test/java/org/apache/deltaspike/test/jsf/impl/injection/uc002/InjectionDroneTest.java:
        convertedValue.sendKeys("DeltaSpike");
   
src/test/java/org/apache/deltaspike/test/jsf/impl/injection/uc003/InjectionDroneTest.java:
        convertedValue.sendKeys("DeltaSpike");
   
src/test/java/org/apache/deltaspike/test/jsf/impl/injection/uc004/InjectionDroneTest.java:
        convertedValue.sendKeys("DeltaSpike");
   ```
   Not one test sent "Apache".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org