tandraschko commented on code in PR #155: URL: https://github.com/apache/deltaspike/pull/155#discussion_r1528246035
########## deltaspike/modules/partial-bean/impl/src/test/java/org/apache/deltaspike/test/core/api/partialbean/uc013/MethodLevelCacheInterceptorTest.java: ########## @@ -75,17 +66,14 @@ public static WebArchive war() @Test public void testMethodLevelInterceptor() throws Exception { - // this test is known to not work under weld-2.0.0.Final and weld-2.0.0.SP1 - Assume.assumeTrue(!CdiContainerUnderTest.is(CONTAINER_WELD_2_0_0)); - MyRepository myRepository = BeanProvider.getContextualReference(MyRepository.class); List<String> users = myRepository.getAllUsers(); Assert.assertNotNull(users); Assert.assertEquals(3, users.size()); - Assert.assertSame(users, myRepository.getAllUsers()); + Assert.assertEquals(users, myRepository.getAllUsers()); Review Comment: There is no serialization here The interceptor caches the method return value If it doesnt, its still broken for weld Therefore the exclude propably -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org