I'd say a separate "presentation" element, *Format, *Formatter, *Renderer
or what we think sounds best.

At least JSON would normally be Locale neutral so maybe Renderer sounded
better for that, but other suggestions welcome.

Werner

On Tue, Dec 30, 2014 at 6:37 PM, Reza Naghibi <
[email protected]> wrote:

> Just to be clear, whats the proposed change?
>
>
>
>
> <div>-------- Original message --------</div><div>From: Volkan Yazıcı <
> [email protected]> </div><div>Date:12/30/2014  11:12 AM
> (GMT-05:00) </div><div>To: [email protected] </div><div>Cc:
> </div><div>Subject: Re: JSON toString methods in data classes </div><div>
> </div>I agree. While it is not a big problem, it looks like an ad-hoc hack
> in its
> current form. Further, I believe its consumer's responsibility to pick the
> format for marshalling. Even if JSON is the way to go, we shouldn't be
> writing our own JsonParser class -- whose name implies a parser but which
> is actually a formatter -- and use a more decent library for that purpose,
> I believe. Anyway, not a big issue. If the rest approves the change, I can
> come up with a patch.
>
> On Tue, Dec 30, 2014 at 4:37 PM, Werner Keil <[email protected]>
> wrote:
>
> > Maybe we can abstract that a bit, e.g. a formatter/renderer that offers
> > multiple output options. Whatever is best as default could be used behind
> > toString() if JSON is best, why not, but it would be good to abstract
> data
> > from the output/representation.
> >
> > Werner
> >
> >
> >
> > On Tue, Dec 30, 2014 at 2:19 PM, Reza Naghibi <
> > [email protected]> wrote:
> >
> > > JSON is used in our servlet, spring, and console examples.
> > >
> > >
> > >
> > > <div>-------- Original message --------</div><div>From: Volkan Yazıcı <
> > > [email protected]> </div><div>Date:12/30/2014  5:02 AM
> > (GMT-05:00)
> > > </div><div>To: [email protected] </div><div>Cc:
> > > </div><div>Subject: JSON toString methods in data classes </div><div>
> > > </div>Hi,
> > >
> > > Is there a particular reason for why are we returning JSON formatted
> > output
> > > from toString() methods of o.a.d.data.* classes? This convention is not
> > > followed by .NET/VB clients, if I am not mistaken.
> > >
> > > Best.
> > >
> >
>

Reply via email to