Yes, of course, the test is against the patternId and you can include optional attributes:
http://wiki.apache.org/devicemap/DataSpec2#line-365 The obvious reason here is that there is logic which drives the attributes. So its important to be able to test this logic. Attributes can be transformed from the original pattern, like pulling out a version or model number, and they can be inherited, example genericAttributes. I havent included attribute tests in the json files, but I plan to do so very soon... :) On Mon, Jul 20, 2015 at 3:31 PM, Volkan Yazıcı <volkan.yaz...@gmail.com> wrote: > Reza, in the tests can we match over a certain field? That is, in addition > to {"input": "Mozilla/5.0 (iPad; ...", "resultPatternId": "ipad"}, can we > also say {"input": "Mozilla/5.0 (iPad; ...", "match": {"brand": "Apple", > "model": "ipad"}}? > > On Mon, Jul 20, 2015 at 9:16 PM, Reza Naghibi <re...@apache.org> wrote: > > > > https://svn.apache.org/repos/asf/devicemap/trunk/data/2.0/reference/device/ > > > > So I quickly mocked up how 2 devices would look in 2.0 (iphone and ipad). > > > > > > On Mon, Jul 20, 2015 at 2:47 PM, Reza Naghibi <r...@naghibi.com> wrote: > > > > > For now its best to ask questions. I will make another reference > domain, > > > reference_b, with user-agent examples shortly. However, those tests > will > > be > > > moved to the actual device/browser/os specific domains and will likely > > not > > > remain as part of the official reference domain (when we release 2.0). > > The > > > reference domain should be as close to spec as possible without moving > > into > > > any kind of specific domain like devices, browsers, etc. > > > > > > On Mon, Jul 20, 2015 at 2:23 PM, Volkan Yazıcı < > volkan.yaz...@gmail.com> > > > wrote: > > > > > > > Hello Reza, > > > > > > > > I checked the attached sample files, they are looking all right. I > > could > > > > not totally grasp the context (probably due to my lack of further > user > > > > experience) but sample files with some real data would make things > more > > > > clear for people like me. I mean, instead of "lorem ipsum", real > > > User-Agent > > > > strings, etc. Apart from that, good job! > > > > > > > > Best. > > > > > > > > On Sat, Jul 11, 2015 at 2:01 AM, Reza Naghibi <re...@apache.org> > > wrote: > > > > > > > > > The reference_a domain has been committed here: > > > > > > > > > > > > https://svn.apache.org/repos/asf/devicemap/trunk/data/2.0/reference/a/ > > > > > > > > > > > > > > > On Fri, Jul 10, 2015 at 5:06 PM, Reza Naghibi <re...@apache.org> > > > wrote: > > > > > > > > > > > So I just wrote the first 2.0 reference domain and test suite. > Its > > > > called > > > > > > reference_a. > > > > > > > > > > > > Apache SVN is down at the moment, so im attaching the domain and > > test > > > > > > suite. I will commit it when SVN becomes available. > > > > > > > > > > > > Some notes on the test suites: > > > > > > > > > > > > https://wiki.apache.org/devicemap/DataSpec2#Test_Suites > > > > > > > > > > > > This is the first of several reference domains and test suites. > > This > > > > one > > > > > > is pretty simple and gives me enough to start writing the > reference > > > > > client. > > > > > > The next step is the write the actual reference client. I will > > begin > > > > this > > > > > > on Monday. After that, I will create a few more reference domains > > > > > > (reference_b, reference_c, etc) which go more deeply into the > spec, > > > > then > > > > > I > > > > > > will refine the client, refine the spec, repeat. When this > process > > is > > > > all > > > > > > said and done, 2.0 is ready from a specification standpoint! This > > is > > > > > > obviously an open process, so feel free to join in and comment, > > etc. > > > > > > > > > > > > The reference client will be written in Java, but will strive to > be > > > as > > > > > > clear, readable and vanilla as possible. This will not be the > > > official > > > > > Java > > > > > > client since performance is not a requirement here. Official > > clients > > > > > should > > > > > > be written for performance, maintainability, and correctness. > > > > > > > > > > > > When the specification is ready (shooting for August), people can > > > start > > > > > > contributing clients. As long as they pass the reference test > > suites, > > > > > they > > > > > > will be valid. At minimum, you should be able to clone or copy > the > > > > > > reference client, assuming the target language is Java-like. > > > Otherwise > > > > > you > > > > > > are free to write the client as you see fit, it just needs to > pass > > > the > > > > > test > > > > > > suites. > > > > > > > > > > > > When the spec is done, I will begin working on the new device, > > > browser, > > > > > > and OS domains. Once again, as long as these domains pass the > > > reference > > > > > > client, they will be good to go. > > > > > > > > > > > > So you should be able to see a theme here, which is that clients > > and > > > > data > > > > > > are completely independent, but together form a nice ecosystem. > > > > > > > > > > > > Let me know if you have any questions, thoughts, commments, etc. > > > > > > Otherwise, sit back, relax, and wait for the reference client. > > > > > > > > > > > > > > > > > > > > > > > > > > >
