MarcViola opened a new issue, #7089: URL: https://github.com/apache/incubator-devlake/issues/7089
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues. ### What happened A gitlab project allows a pipeline to pass even though a deployment to production job fails (with option allow_failure: true) So we have a situation where there was no deployment to production but DevLake counted it as a sucessful deployment in DORA. Here are the conditions we verified:  ### What do you expect to happen We expect the deployment not to count in the DORA metrics as a successfull deployment if the job fails, regardless of the status of the pipeline. ### How to reproduce Create a pipeline in gitlab with 2 jobs. 1 test and 1 deploy. The deploy must have option allow_failure: true Make the test job pass, and the deploy job fails. When the pipeline runs, the status of the pipeline will be "Warning" because the test job passed and the deploy job was allowed to fail. Configure DevLake to count the "deploy" as deployment to prod in gitlab. ### Anything else _No response_ ### Version v0.21.0-beta4@9192e52 ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@devlake.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
