petkostas commented on issue #8188:
URL:
https://github.com/apache/incubator-devlake/issues/8188#issuecomment-3217084639
I am re-opening this as it is still affecting some of our repositories and
raising questions from engineering teams.
I took some time to think about a possible approach which would possibly
reduce the effect.
@Startrekzky
I am thinking of the following approach:
Adjust `getDeploymentCommit` to use a two-phase strategy:
- Direct match: if there exists a successful PRODUCTION deployment in the
project whose `commit_sha` equals the PR’s merge commit, return it. This is
precise and does not risk the first-deployment over-mapping problem.
- Fallback to diff-based mapping: retain the current strategy (including
the filter `dc.prev_success_deployment_commit_id <> ''`) to avoid mapping to
the first deployment via diffs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
