mcseemz opened a new issue, #8829:
URL: https://github.com/apache/incubator-devlake/issues/8829

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   With the properly configured teams Grafana Work Logs dashboard could not 
select user after team selection, and then could not produce any data on a 
panel. I suspect there are a number of other boards with the same problem.
   
   <img width="375" height="63" alt="Image" 
src="https://github.com/user-attachments/assets/358047a1-da2c-433f-a3ba-76ab992dcdc8";
 />
   
   ### What do you expect to happen
   
   User dropdown works successfully, leading to proper data in panels for all 
boards relying on "teams" and "users" DB tables
   
   ### How to reproduce
   
   Problem is with the teams' and users' IDs. DB fields for those are 
`varchar(255)`, so we can put any string there (although examples are with 
numbers only for some reasons). 
[Documentation](https://devlake.apache.org/docs/v0.15/UserManuals/TeamConfiguration)
 says nothing about field contents.
   And then dashboard' variables and panels do not quote these IDs data in SQL, 
e.g.:
   
https://github.com/apache/incubator-devlake/blob/main/grafana/dashboards/WorkLogs.json#L1447
   ```
   "query": "select concat(users.name, '--', users.id) from users left join 
team_users on users.id = team_users.user_id where team_users.team_id in 
($team)",
   ```
   So it works well only with numbers right now, as they are injected safely. 
Please decide, either numbers only, or string support in grafana (I would vote 
for the second).
   
   ### Anything else
   
   The [regexp 
logic](https://github.com/apache/incubator-devlake/blob/adaa0085711687f52b991f0347479496d0a0de3d/grafana/dashboards/WorkLogs.json#L1449)
 applied to the dashboard variables to compile proper dropdown implies bit does 
not state anywhere that team or user ID should not contain `--` , or everything 
will break apart.
   
   ### Version
   
   v1.0.3-beta10
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to