dosubot[bot] commented on issue #8834:
URL: 
https://github.com/apache/incubator-devlake/issues/8834#issuecomment-4238308333

   <!-- Answer -->
   Glad the analysis matched what you're seeing. Your preference for option 2 
(moving the `board_id` condition into the ON clause) makes sense — that would 
preserve all collected changelogs in the domain layer regardless of collection 
path, which is the correct behavior.
   
   I don't have visibility into the maintainers' roadmap or release timeline, 
so I can't speak to when a fix might land. Since you've confirmed the root 
cause and the data impact is significant (4%–99% missing changelogs across 
projects), this issue is well-documented enough for someone to pick up. The fix 
itself is relatively contained — the core change in 
`issue_changelog_convertor.go` is moving `_tool_jira_board_issues.board_id = ?` 
from the WHERE clause into the LEFT JOIN's ON clause. But as noted, the same 
anti-pattern exists in 8+ other converter files, so an audit of those would be 
valuable as part of a broader fix.
   
   If you or someone on your team is able to submit a PR, that would likely be 
the fastest path to a fix. The scope is well-defined and the change is low-risk 
for the changelog converter specifically.
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention 
[@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=brand-link).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-great_response#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-irrelevant_answer#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-incorrect_sources#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-too_verbose#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=too_verbose)
 | [Hallucination](https://
 
app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-hallucination#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-bug_report#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-other#message_id=327c017a-4b6c-4ca9-bd7d-8f98948ebe67&feedback_type=other)</sup>
   [![Chat with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/b4e8e847-d479-4541-83a8-d88d83fea5c9/ask?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=chat-badge)&nbsp;[![Open
 in 
Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=Glad%20the%20analysis%20matched%20what%20you%27re%20seeing.%20Your%20preference%20for%20option%202%20%28moving%20the%20%60board_id%60%20condition%20into%20the%20ON%20clause%29%20makes%20sense%20%E2%80%94%20that%20would%20preserve%20all%20collected%20changelogs%20in%20the%20domain%20layer%20regardless%20of%20collection%20path%2C%20which%20is%20the%20correct%20behavior.%0A%0AI%20don%27t%20have%20visibility%20into%20the%20maintainers%27%20roadmap%20or%20release%20timeline%2C%20so%20I%20can%27t%20speak%20to%20when%20a%20fix%20might%20land.%20Since%20you%27ve%20confirmed%20the%20root%20cause%20and%20the%20data%20impact%20is%20significant%20%284%25%E2%80%9399%25%20missing%20chang
 
elogs%20across%20projects%29%2C%20this%20issue%20is%20well-documented%20enough%20for%20someone%20to%20pick%20up.%20The%20fix%20itself%20is%20relatively%20contained%20%E2%80%94%20the%20core%20change%20in%20%60issue_changelog_convertor.go%60%20is%20moving%20%60_tool_jira_board_issues.board_id%20%3D%20%3F%60%20from%20the%20WHERE%20clause%20into%20the%20LEFT%20JOIN%27s%20ON%20clause.%20But%20as%20noted%2C%20the%20same%20anti-pattern%20exists%20in%208%2B%20other%20converter%20files%2C%20so%20an%20audit%20of%20those%20would%20be%20valuable%20as%20part%20of%20a%20broader%20fix.%0A%0AIf%20you%20or%20someone%20on%20your%20team%20is%20able%20to%20submit%20a%20PR%2C%20that%20would%20likely%20be%20the%20fastest%20path%20to%20a%20fix.%20The%20scope%20is%20well-defined%20and%20the%20change%20is%20low-risk%20for%20the%20changelog%20converter%20specifically.)&nbsp;[![Join
 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot?utm_sour
 
ce=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=join-discord)&nbsp;[![Share
 on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/incubator-devlake/issues/8834)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to