Hi, I'm also glad to see Kryo support for DirectMemory. Thanks! As you report, Kryo is very fast. And if my Unsafe-based improvements will land in Kryo's trunk, it will become even faster.
One minor note on your patch: I've noticed a spelling error in method names. "regiter" should be "register" I guess :-) -Roman On Sun, Sep 30, 2012 at 7:58 PM, Simone Tripodi (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/DIRECTMEMORY-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466533#comment-13466533 > ] > > Simone Tripodi commented on DIRECTMEMORY-103: > --------------------------------------------- > > Very well done, congrats and thanks for contributing! I am going to checkin > your patch. > > A small hint: it is best practice here at DirectMemory naming patch files > with issue id, i.e. {{DIRECTMEMORY-103.patch}} in your case. > > Thanks again! > >> Add another serialization kryo >> ------------------------------ >> >> Key: DIRECTMEMORY-103 >> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-103 >> Project: Apache DirectMemory >> Issue Type: Bug >> Components: Serializers >> Affects Versions: 0.2 >> Reporter: Min Zhou >> Assignee: Simone Tripodi >> Attachments: kryo.diff >> >> >> Kryo is the most efficient serialization written in java that is widely >> used. From our benchmark, the unsafe MemoryManagerService based on kryo is >> 4x faster than that of msgpack. One of the major reason is that kryo can >> more efficiently check if the class has been registered or not. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira
