Hi Chris! we just received Craig's acknowledge, we'll start the import process ASAP! :)
Thanks a lot, have a nice day! all the best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Oct 1, 2012 at 10:23 PM, Noctarius <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Ok Craig confirmed the SG for Lightning contribution :-) > > Something more to do? > > Am 01.10.2012 12:43, schrieb Simone Tripodi: >> No problem Chris ;) >> >> we all committers are here also to welcome new lifeblood, like >> you, and help them on being part of the ASF ecosystem in the >> easier way, so I am glad to provide you as much info as I can - >> being the discussion public, everybody can jump in and provide >> even more info... isn't that cool? :) >> >> Have a nice day, all the best!!! -Simo >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi http://www.99soft.org/ >> >> >> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius <[email protected]> >> wrote: Hey Simone, >> >> alright it's on it's way :-) Thanks for the explanation. >> >> Like I mentioned earlier in the thread I never thought about >> contributing it to the ASF so I haven't really looked on how a >> contribution needs to be done. >> >> Cheers Chris >> >> Am 01.10.2012 12:22, schrieb Simone Tripodi: >>>>> Hi Chris, >>>>> >>>>> thanks for the follow-up! >>>>> >>>>> I that see releases haven't been pushed yet, but >>>>> unfortunately there is a rather that small codebase that >>>>> is going to be donated - what I suggest you, in order to >>>>> avoid any possible legal mistake, is submitting the >>>>> SoftwareGrant[1] I linked you in the previous message; >>>>> that would make clear that the codebase on github is >>>>> going to be donated to the ASF. >>>>> >>>>> What you have to do is pretty simple: like the ICLA, >>>>> print the file, fill the few info, sign it and send the >>>>> scanned version to secretary@, you should shortly receive >>>>> the recorded SG notification. >>>>> >>>>> HTH, have a nice day! -Simo >>>>> >>>>> [1] http://www.apache.org/licenses/software-grant.txt >>>>> >>>>> http://people.apache.org/~simonetripodi/ >>>>> http://simonetripodi.livejournal.com/ >>>>> http://twitter.com/simonetripodi http://www.99soft.org/ >>>>> >>>>> >>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius >>>>> <[email protected]> wrote: Hi Simone, >>>>> >>>>> no problem for misinterpreting it :) I thought something >>>>> like that. >>>>> >>>>> By now there is no release of Lightning, just the >>>>> original sourcecode on Github. Lightning wasn't fully >>>>> production ready and I worked on releasing the first >>>>> version. >>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open >>>>> >>>>> >> >>>>> > :-) >>>>> >>>>> I'm not sure if this needs a "software grant", whatever >>>>> this is :-) >>>>> >>>>> Cheers Chris >>>>> >>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi: >>>>>>>> Hi Guys, >>>>>>>> >>>>>>>> that perfectly explains why I didn't understand >>>>>>>> the contribution, please accept my apologize for >>>>>>>> misinterpreting it and, above all, for not having >>>>>>>> followed the main thread. >>>>>>>> >>>>>>>> So, big +1 for having lightning aboard as both >>>>>>>> subproject and serializer module, my added proposal >>>>>>>> is to separate main DM trunk and lightning >>>>>>>> lifecycle in order to not make releases depending >>>>>>>> each other. >>>>>>>> >>>>>>>> Before importing Christoph codebase: I already >>>>>>>> noticed he already signed the ICLA, but what about >>>>>>>> the original codebase? If lightning already >>>>>>>> published some releases outside the ASF, Christoph >>>>>>>> should submit a SoftwareGrant[1] to donate his >>>>>>>> codebase to the ASF. If it was already done, we are >>>>>>>> ready to import lightning!! :) >>>>>>>> >>>>>>>> Have a nice day, -Simo >>>>>>>> >>>>>>>> [1] >>>>>>>> http://www.apache.org/licenses/software-grant.txt >>>>>>>> >>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>> http://simonetripodi.livejournal.com/ >>>>>>>> http://twitter.com/simonetripodi >>>>>>>> http://www.99soft.org/ >>>>>>>> >>>>>>>> >>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi >>>>>>>> <[email protected]> wrote: >>>>>>>>> We were talking about separating the contribution >>>>>>>>> in two pieces: lightning itself as a subproject >>>>>>>>> under the directmemory/lightning folder and then >>>>>>>>> the serializer module for directmemory in the >>>>>>>>> serialization folder. >>>>>>>>> >>>>>>>>> Agreed to the coding style consideration (I >>>>>>>>> forgot about it) and -regarding the ignore >>>>>>>>> annotation - I found many of them in the main >>>>>>>>> package, I think the point is that they have been >>>>>>>>> moved to another module (more appropriate) and >>>>>>>>> never deleted. >>>>>>>>> >>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone >>>>>>>>> Tripodi (JIRA)" <[email protected]> ha scritto: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> [ >>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467] >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>> >>>>>>>>>> >> >>>>>>>>>> > Simone Tripodi commented on DIRECTMEMORY-102: >>>>>>>>>> --------------------------------------------- >>>>>>>>>> >>>>>>>>>> Hi Christoph, >>>>>>>>>> >>>>>>>>>> thanks for contributing! Patch looks quiet >>>>>>>>>> good, I'd followup the discussion on the dev@ >>>>>>>>>> ML first, I have some observations about the >>>>>>>>>> inclusion before applying it. I am going to >>>>>>>>>> send a message following up the current thread >>>>>>>>>> in a short while. Thanks *a lot* for the hard >>>>>>>>>> work and congrats for that lib! >>>>>>>>>> >>>>>>>>>> In the case you are looking for some >>>>>>>>>> feedbacks, follow below few (ASF general) >>>>>>>>>> suggestions to submit patches: >>>>>>>>>> >>>>>>>>>> _Higher priority_ >>>>>>>>>> >>>>>>>>>> * serializer modules are put under the >>>>>>>>>> [serializers| >>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/] >>>>>>>>>> >>>>>>>>>> >>>>> >>>>>>>>>> >> >>>>>>>>>> > directory; >>>>>>>>>> >>>>>>>>>> * no tabs; 2 spaces for XML sources, 4 spaces >>>>>>>>>> for Java sources - generally, please respect >>>>>>>>>> the original source code format, people here if >>>>>>>>>> following the Apache Maven [code conventions| >>>>>>>>>> http://maven.apache.org/developers/conventions/code.html] >>>>>>>>>> >>>>>>>>>> >> >>>>>>>>>> > (IDEs config included); >>>>>>>>>> >>>>>>>>>> * According to other serializer modules, the >>>>>>>>>> package should be moved to >>>>>>>>>> {{org.apache.directmemory.serialization.lightning}}; >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> > * No needs to define and implement yet another >>>>>>>>>> logging abstraction level/façade: >>>>>>>>>> >>>>>>>>>> * No needs to define a >>>>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the reference >>>>>>>>>> interface can be directly the >>>>>>>>>> [org.apache.directmemory.serialization.Serializer| >>>>>>>>>> >>>>>>>>>> > https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java] >>>>>>>>>> >>>>>>>>>> >>>>> >>>>>>>>>> >> class; >>>>>>>>>> >>>>>>>>>> _Lower priority_ >>>>>>>>>> >>>>>>>>>> * please name patch file with the issue key, >>>>>>>>>> i.e. {{DIRECTMEMORY-102.patch}}, it helps >>>>>>>>>> committers that are reviewing and applying >>>>>>>>>> patches; >>>>>>>>>> >>>>>>>>>> * In the following code: >>>>>>>>>> >>>>>>>>>> {code} +@SuppressWarnings("serial") +public >>>>>>>>>> class ClassDefinitionInconsistentException >>>>>>>>>> extends RuntimeException { {code} >>>>>>>>>> >>>>>>>>>> you don't need to suppress the serial, you can >>>>>>>>>> add serialVersionUID field; >>>>>>>>>> >>>>>>>>>> * same for {{IllegalAccessorException}}; >>>>>>>>>> >>>>>>>>>> * same for {{IllegalPropertyAccessException}}; >>>>>>>>>> >>>>>>>>>> * same for {{SerializerDefinitionException}}; >>>>>>>>>> >>>>>>>>>> * same for {{SerializerExecutionException}}; >>>>>>>>>> >>>>>>>>>> * same for >>>>>>>>>> {{SerializerMarshallerGeneratorException}}; >>>>>>>>>> >>>>>>>>>> * Please drop {{@author}} tags, feel free to >>>>>>>>>> add yourself in the {{contributors}} section in >>>>>>>>>> the parent POM - this is the right place where >>>>>>>>>> people are enlisted; >>>>>>>>>> >>>>>>>>>> * no needs to define a {{StringUtil}} class >>>>>>>>>> unless [Guava| >>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained] >>>>>>>>>> >>>>>>>>>> >> >>>>>>>>>> > doesn't provide the functionalities you need; the >>>>>>>>>> DirectMemory core module relies on Guava; >>>>>>>>>> >>>>>>>>>> * same for {{TypeUtil}} >>>>>>>>>> >>>>>>>>>> * why {{Benchmark}} class is annotated with >>>>>>>>>> {{@Ignore}}? >>>>>>>>>> >>>>>>>>>>> Lightning Serializer Contribution >>>>>>>>>>> --------------------------------- >>>>>>>>>>> >>>>>>>>>>> Key: DIRECTMEMORY-102 URL: >>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102 >>>>>>>>>>> >>>>>>>>>> >> >>>>>>>>>> > Project: Apache DirectMemory Issue Type: New Feature >>>>>>>>>>> Components: Serializers Reporter: Christoph >>>>>>>>>>> Engelbert Attachments: >>>>>>>>>>> lightning_contribution.patch >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> This is the first contribution patch attempt >>>>>>>>>>> for the lightning >>>>>>>>>> serializer. If there are any things need to be >>>>>>>>>> changed please let me know. >>>>>>>>>>> PS: The issue tracker and sourcelocation >>>>>>>>>>> values in the pom.xml aren't >>>>>>>>>> set yet, since I had no clue what are the >>>>>>>>>> correct values but I guess that could be set >>>>>>>>>> later on. >>>>>>>>>> >>>>>>>>>> -- This message is automatically generated by >>>>>>>>>> JIRA. If you think it was sent incorrectly, >>>>>>>>>> please contact your JIRA administrators For >>>>>>>>>> more information on JIRA, see: >>>>>>>>>> http://www.atlassian.com/software/jira >>>>>>>>>> >>>>> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.12 (MingW32) > Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJQafvLAAoJEH/g+YBfahrqF+AQAK6J4G32QIUyLeCNcB87+fIR > J+FtxsPFIGNajoQGsgBsc+pE9DziiNfiZFzjHoWG8sCl/L21zGrR157qz7npc0dB > 9ty/wBqsLg294vZ0cxaBoBk6qZZAUUXMAFZVhf3farLikqYELEi5RKSxzKlyXX4z > rpha5f8elDTPIoZU+jnHV0gHhhqOeG1MRR+QrM69/LalnokgfhU38k1vORvDSabF > JxwYFGvFtVYQWQBp+Lfkc/a3cEoVGSn3Qd8zYU5NlobT8bIqsxn55HblCaiuMJ8f > 3JRXuSaMrAZaffEQN8743ucgy8cnosZDSGgBxWyVNsx+asn+KGlnhArMlAmgGgzl > /Veq9njhrPR6sAyAlvZ78YuzaAcziKX7JzF12wL+LHTbR2E1q5EWXPPbNmgfgBoL > u5z/L4XOWItA+MlNpKD8hxn2jmiY0M8NJNpEybuiCIf/nxOYtTk2K6JH1gckoLmW > ZhECft2LC7c/t24QpB1h62sBJ8Df+n02v+d4mJPShIYeYYDiaL47Ms5yjPaxu+pX > FuOqF97p6xaIq6fh73cQzGBZhbaXjudfOV9fcTSawkII8z0UA9vD9RovFqn7Otdv > jGhbyCC5Uajng9Ge7VuM+Xv3WKg4hduSZfKNXIP5/5WtmBQKIo3xGo4gnj5I39PI > NxkC48CLtTKRi8nJ1uzL > =fYJo > -----END PGP SIGNATURE-----
