RE: [jira] Commented: (DIRMINA-121) Per-port filter chain

[Irving, Dave]

> Whatever concurrency issues are here, we have them in the code today, as I am not changing the API and a session can > modify its chain any time it wants. Even when still processing the previous event on a separate thread, a session-thread can start > changing its chain and hence modifying NextFilter on another thread.   > Not sure what you want to do about it.   I think we discussed this yesterday. AbstractIoFilterChain takes care of this today as the NextFilter given to filters takes care of chain modifications internally. Looking up a filter and using it has a much bigger concurrency risk - as the ownus is on the filter implementation to manage concurrency rather than the framework. Of course, you can still manage this internally (which is what im proposing), but you seem to be very much against anything which keeps NextFilter around :o) From: Jose Alberto Fernandez [mailto:[EMAIL PROTECTED] Sent: 17 November 2005 12:37 To: Apache Directory Developers List Subject: RE: [jira] Commented: (DIRMINA-121) Per-port filter chain     From: Trustin Lee [mailto:[EMAIL PROTECTED] Right, there's no need to remember NextFilter with getNextFilter() methods.  But it doesn't mean that IoFilterChain can update the reference to NextFilter in runtime because it will raise concurrency issue definitely. Whatever concurrency issues are here, we have them in the code today, as I am not changing the API and a session can modify its chain any time it wants. Even when still processing the previous event on a separate thread, a session-thread can start changing its chain and hence modifying NextFilter on another thread.   Not sure what you want to do about it.   Jose Alberto   This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.