[ http://issues.apache.org/jira/browse/DIRMINA-165?page=comments#action_12363218 ]
Trustin Lee commented on DIRMINA-165: ------------------------------------- Your patch is very error-prone. What about this? * Provide all methods like duplicate, asReadOnlyBuffer, slice, ... * To invoke these methods, 'pooled' property must be false. * 'pooled' property of all derived buffers and its parent buffer must be 'false' and cannot be changed anymore. In case of broadcasting only, we could provide more effective solution as we discussed in DIRMINA-42. WDYT? > Easy and performant copy of the ByteBuffer > ------------------------------------------ > > Key: DIRMINA-165 > URL: http://issues.apache.org/jira/browse/DIRMINA-165 > Project: Directory MINA > Type: Improvement > Versions: 0.8, 0.9, 0.8.1, 0.8.2 > Reporter: Federico Bonelli > Priority: Minor > Attachments: ByteBuffer.java, HubServer_broadCastTCPmessages.zip > > Until now if you wish to broadcast a message you must create by your own the > bytebuffer copies, it would be better to provide a ByteBuffer.asReadOnly() > method that create a copy that share the data with the original ByteBuffer -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
